Skip to content

Conversation

@tchajed
Copy link
Contributor

@tchajed tchajed commented Nov 23, 2021

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` ocaml OCaml use is a significant feature of the PR or issue labels Nov 23, 2021
SMillerDev
SMillerDev previously approved these changes Nov 23, 2021
@tchajed
Copy link
Contributor Author

tchajed commented Nov 23, 2021

The error is an audit failure "Libraries were compiled with a flat namespace" in all the cmxs files.

I don't really understand how to fix this, or what might have changed. It does seem OCaml passes this flag: https://github.com/ocaml/ocaml/blob/3fa2cfce074d0a83225d7a21678b971bad959a7f/configure.ac#L954.

@tchajed
Copy link
Contributor Author

tchajed commented Nov 23, 2021

I confirmed that the same error now appears when auditing coq 8.13.2 and 8.14.0, which is a relief since I wouldn't expect anything to have changed upstream.

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 23, 2021
@carlocab
Copy link
Member

carlocab commented Nov 23, 2021

It does seem OCaml passes this flag: https://github.com/ocaml/ocaml/blob/3fa2cfce074d0a83225d7a21678b971bad959a7f/configure.ac#L954.

Yep. It shouldn't, though: ocaml/ocaml#10723

We've patched this in Homebrew OCaml:

# Remove use of -flat_namespace. Upstreamed at
# https://github.com/ocaml/ocaml/pull/10723
# We embed a patch here so we don't have to regenerate configure.
patch :p0, :DATA
# Fix -flat_namespace being used on Big Sur and later.
patch do
url "https://raw.githubusercontent.com/Homebrew/formula-patches/03cf8088210822aa2c1ab544ed58ea04c897d9c4/libtool/configure-big_sur.diff"
sha256 "35acd6aebc19843f1a2b3a63e880baceb0f5278ab1ace661e57a502d9d78c93c"
end

carlocab
carlocab previously approved these changes Nov 24, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -flat_namespace flag comes from OCaml, so should be fixed there. I think we can ignore the audit for now, since it should be fixed when OCaml is updated.

The `-flat_namespace` flag comes from OCaml, and should go away when the
OCaml bottles are rebuilt.
@carlocab carlocab dismissed stale reviews from SMillerDev and themself via 2a4cba3 November 24, 2021 13:51
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 24, 2021
@BrewTestBot
Copy link
Contributor

:shipit: @carlocab has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. ocaml OCaml use is a significant feature of the PR or issue outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants