-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
coq 8.14.1 #89870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coq 8.14.1 #89870
Conversation
|
The error is an audit failure "Libraries were compiled with a flat namespace" in all the cmxs files. I don't really understand how to fix this, or what might have changed. It does seem OCaml passes this flag: https://github.com/ocaml/ocaml/blob/3fa2cfce074d0a83225d7a21678b971bad959a7f/configure.ac#L954. |
|
I confirmed that the same error now appears when auditing coq 8.13.2 and 8.14.0, which is a relief since I wouldn't expect anything to have changed upstream. |
Yep. It shouldn't, though: ocaml/ocaml#10723 We've patched this in Homebrew OCaml: homebrew-core/Formula/ocaml.rb Lines 40 to 49 in ccd98dd
|
carlocab
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -flat_namespace flag comes from OCaml, so should be fixed there. I think we can ignore the audit for now, since it should be fixed when OCaml is updated.
The `-flat_namespace` flag comes from OCaml, and should go away when the OCaml bottles are rebuilt.
Created with
brew bump-formula-pr.