Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lm4tools: fix ARM build #88207

Closed
wants to merge 1 commit into from
Closed

lm4tools: fix ARM build #88207

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

There is a hardcoded /usr/local reference that prevents the build from
being able to find libusb.

@carlocab carlocab added CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. labels Oct 28, 2021
@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle labels Oct 28, 2021
@iMichka
Copy link
Member

iMichka commented Oct 28, 2021

Can we upstream a patch? Or at least open an issue for this upstream?

@carlocab
Copy link
Member Author

They have a 40-line handcrafted Makefile that probably isn't really intended to be portable. Usually, these things you have to edit yourself if the defaults don't work. But let's see if I can find time to send a patch.

@carlocab
lm4tools: fix ARM build
8455f8a 
There is a hardcoded `/usr/local` reference that prevents the build from
being able to find `libusb`.
@Bo98
Copy link
Member

Bo98 commented Oct 29, 2021

They have a 40-line handcrafted Makefile that probably isn't really intended to be portable. Usually, these things you have to edit yourself if the defaults don't work. But let's see if I can find time to send a patch.

I suppose the patch would be to use the pkg-config route if available, and then fall back to the defaults.

@SMillerDev SMillerDev added the upstream issue An upstream issue report is needed label Nov 1, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the lm4tools-arm branch November 1, 2021 10:21
@carlocab carlocab mentioned this pull request Nov 1, 2021
Open
@carlocab
Copy link
Member Author

carlocab commented Nov 1, 2021

Opened utzig/lm4tools#32.

@github-actions github-actions bot added the outdated PR was locked due to age label Dec 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

Assignees
No one assigned
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlocab @iMichka @Bo98 @BrewTestBot @SMillerDev