Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: remove linux build #87142

Closed
wants to merge 1 commit into from
Closed

envoy: remove linux build #87142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions Formula/envoy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ class Envoy < Formula
license "Apache-2.0"

# Apple M1/arm64 is pending envoyproxy/envoy#16482
# Linux is unsupported due to complexity, frequent maintenance and long build times.
bottle do
sha256 cellar: :any_skip_relocation, big_sur: "5d242c76931465e1bebc4ac62742bcdd68a42334679cc69f8c058e1f7b4147a1"
sha256 cellar: :any_skip_relocation, catalina: "48e53aac4dc4b8c7603141b711730427a5ca94ce4d3e3ce572c1c01cd96ad9f2"
sha256 cellar: :any_skip_relocation, x86_64_linux: "deab2f6221196615ee138102d6496f849b85a11880fcf5b783ec30e07ed78419"
end

depends_on "automake" => :build
Expand All @@ -23,36 +23,14 @@ class Envoy < Formula
depends_on "ninja" => :build
depends_on macos: :catalina

on_linux do
# GCC added as a test dependency to work around Homebrew issue. Otherwise `brew test` fails.
# CompilerSelectionError: envoy cannot be built with any available compilers.
depends_on "gcc@9" => [:build, :test]
depends_on "python@3.9" => :build
end

# https://github.com/envoyproxy/envoy/tree/main/bazel#supported-compiler-versions
fails_with gcc: "5"
fails_with gcc: "6"
# GCC 10 build fails at external/com_google_absl/absl/container/internal/inlined_vector.h:469:5:
# error: '<anonymous>.absl::inlined_vector_internal::Storage<char, 128, std::allocator<char> >::data_'
# is used uninitialized in this function [-Werror=uninitialized]
fails_with gcc: "10"
# GCC 11 build fails at external/boringssl/src/crypto/curve25519/curve25519.c:503:57:
# error: argument 2 of type 'const uint8_t[32]' with mismatched bound [-Werror=array-parameter=]
fails_with gcc: "11"

# Work around xcode 12 incompatibility until envoyproxy/envoy#17393
patch do
url "https://github.com/envoyproxy/envoy/commit/3b49166dc0841b045799e2c37bdf1ca9de98d5b1.patch?full_index=1"
sha256 "e65fe24a29795606ea40aaa675c68751687e72911b737201e9714613b62b0f02"
end

def install
env_path = if OS.mac?
"#{HOMEBREW_PREFIX}/bin:/usr/bin:/bin"
else
"#{Formula["python@3.9"].opt_libexec}/bin:#{env_path}"
end
env_path = "#{HOMEBREW_PREFIX}/bin:/usr/bin:/bin"
args = %W[
--compilation_mode=opt
--curses=no
Expand Down