Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-cli 1.22.2 #85274

Closed

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` go Go use is a significant feature of the PR or issue labels Sep 16, 2021
@chenrui333
Copy link
Member Author

chenrui333 commented Sep 16, 2021

==> /opt/homebrew/Cellar/kubernetes-cli/1.22.2/bin/kubectl version --client 2>&1
Error: kubernetes-cli: failed
An exception occurred within a child process:
  Minitest::Assertion: Expected /GitTreeState:"clean"/ to match "Client Version: version.Info{Major:\"1\", Minor:\"22+\", GitVersion:\"v1.22.2-dirty\", GitCommit:\"8b5a19147530eaac9476b0ab82980b4088bbc1b2\", GitTreeState:\"dirty\", BuildDate:\"2021-09-15T21:31:32Z\", GoVersion:\"go1.17\", Compiler:\"gc\", Platform:\"darwin/arm64\"}\n".

Somehow the git checkout becomes dirty checkout.

Relates to https://github.com/kubernetes/kubernetes/blob/03ccab222b78bd00f57d9f677136bf7c22bd4f19/hack/lib/version.sh#L68-L95


changelog, kubernetes/kubernetes@v1.22.1...v1.22.2 (did not find anything interesting)

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 16, 2021
@branchvincent
Copy link
Member

upstream builds with go 1.16 while we're on 1.17, and somewhere they must be running go fmt. not sure how we didn't see this in #83413

diff --git a/cmd/kubeadm/app/apis/bootstraptoken/v1/zz_generated.deepcopy.go b/cmd/kubeadm/app/apis/bootstraptoken/v1/zz_generated.deepcopy.go
index 60e9998c35d..1dcf76cb9b9 100644
--- a/cmd/kubeadm/app/apis/bootstraptoken/v1/zz_generated.deepcopy.go
+++ b/cmd/kubeadm/app/apis/bootstraptoken/v1/zz_generated.deepcopy.go
@@ -1,3 +1,4 @@
+//go:build !ignore_autogenerated
 // +build !ignore_autogenerated
 
 /*

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Sep 22, 2021
@github-actions github-actions bot closed this Sep 23, 2021
@chenrui333 chenrui333 reopened this Sep 29, 2021
@chenrui333 chenrui333 removed the stale No recent activity label Sep 29, 2021
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Sep 29, 2021
@branchvincent
Copy link
Member

Interesting, what changed?

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333
Copy link
Member Author

nothing changed, k8s-cli build is always weird like this.

@chenrui333 chenrui333 deleted the bump-kubernetes-cli-1.22.2 branch September 29, 2021 04:40
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants