-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envoy 1.19.1 #83921
envoy 1.19.1 #83921
Conversation
@chenrui333 ps I switched the syntax to favor automation |
Also I looked at v1.19.1 doesn't include the patch even if the PR was merged. I don't know why but envoy usually doesn't cherry-pick so probably v1.20.0 will be the first version we can kill the patch with |
what an odd failure.. I wonder if it is transient (on ubuntu)
|
3240945
to
efac752
Compare
force pushed just in case the problem is transient |
The error seems to that I believe the following script is run via Bazel's The easiest way to fix would be to switch back to direct Git clone rather than source tarball. |
thanks for the analysis @cho-m so we can switch back I will make a comment basically we can't use automatic update scripts until this is fixed I think. |
@chenrui333 @carlocab would you mind doing the honors? here and #83929? I will raise an issue upstream to see if the project can build without requiring git (so that bump automation can work) out-of-band |
@cho-m thanks for the explanation. I put in a comment so that someone doesn't "fix" this and break it! |
follow-up is here envoyproxy/envoy#17859 |
# TODO: We can't use the tar.gz archive URL, which means bump-homebrew-formula-action doesn't work. | ||
# See https://github.com/envoyproxy/envoy/issues/17859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use https://github.com/marketplace/actions/homebrew-bump-formula instead, but this doesn't need to be documented in the formula.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack for next time, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can nix the comment in a separate syntax-only PR, as this CI run is pretty expensive.
🤖 A scheduled task has triggered a merge. |
Created by https://github.com/mislav/bump-homebrew-formula-action