pastebinit: improve test #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url = shell_output("echo \"Hello world at $(date)\" | pastebinit").chomp | ||
| assert_match %r{^http://pastebin\.com/}, url | ||
| # We can't actually fetch the URL to check the paste's success because pastebin | ||
| # blocks our fetches with curl, probably based on the user agent |
There was a problem hiding this comment.
curl can set its own user agent with -A/--user-agent option, so that can probably be defeated without too much trouble.
There was a problem hiding this comment.
Yeah, but we don't want to defeat it. Our policy is to report homebrew/curl as the user agent, and respect the server side's handling of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install <formula>(where<formula>is the name of the formula you're submitting)?brew audit --strict --online <formula>(after doingbrew install <formula>)?Checks the output of
pastebinitto see if it's actually a URL, indicating the paste succeeded. Unfortunately, we can't check the results on pastebin because it blocks ourcurlfetches, probably based on user agent, and also detects these simple pastes as spammy, so you need to pass a captcha to see them.