Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify commands to edit formula #76865

Merged
merged 2 commits into from
May 9, 2021
Merged

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented May 8, 2021

by using brew edit command.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label May 8, 2021
@davidxia davidxia marked this pull request as ready for review May 8, 2021 19:19
@davidxia davidxia requested a review from MikeMcQuaid as a code owner May 8, 2021 19:19
CONTRIBUTING.md Outdated Show resolved Hide resolved
by using the `brew edit` command.
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davidxia!

@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label May 8, 2021
@dawidd6 dawidd6 merged commit c1d56ed into Homebrew:master May 9, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants