Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 1.7.1 #70018

Closed
wants to merge 1 commit into from
Closed

deno 1.7.1 #70018

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 30, 2021

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Jan 30, 2021
@carlocab
Copy link
Member

Here we go again... denoland/deno#9244

@carlocab
Copy link
Member

[rusty_v8 0.16.0] ninja: error: toolchain.ninja:286: unexpected EOF
[rusty_v8 0.16.0] 
[rusty_v8 0.16.0] thread 'main' panicked at '
[rusty_v8 0.16.0] command did not execute successfully, got: exit code: 1
[rusty_v8 0.16.0] 
[rusty_v8 0.16.0] build script failed, must exit now',

Sigh. I wonder if we can just deparallelise this. It'll take ages, but maybe the builds will get more reliable then.

@carlocab
Copy link
Member

carlocab commented Jan 30, 2021

Commit 11-arm 11 10.15 10.14 CI Logs
62507bbba2c2c2163a9130c852ad96fce76a70de https://github.com/Homebrew/homebrew-core/actions/runs/522491143
7055ee5 https://github.com/Homebrew/homebrew-core/actions/runs/522800304

Let's re-run (by rebasing against the master, so we can check the commits) this a few times without changing the formula. I think that if we have one successful run for each version we can ship the first run that has a successful ARM and Mojave build. Catalina and Big Sur can be bottled after, as long as we know they will bottle if we try enough times.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@chenrui333 chenrui333 deleted the bump-deno-1.7.1 branch January 30, 2021 19:05
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants