Skip to content

opencascade: depend on brewed tcl-tk - #68353

Closed
carlocab wants to merge 2 commits into
Homebrew:masterfrom
carlocab:opencascade-tcl-tk
Closed

carlocab wants to merge 2 commits into
Homebrew:masterfrom
carlocab:opencascade-tcl-tk

Conversation

@carlocab

@carlocab carlocab commented Jan 5, 2021 •

Copy link
Copy Markdown
Member

Fixes CI failure found in #67718. See also #67378.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added missing license Formula has a missing license which should be added no ARM bottle Formula has no ARM bottle labels Jan 5, 2021
@carlocab
carlocab force-pushed the opencascade-tcl-tk branch from 8b361eb to ddfbc51 Compare January 5, 2021 22:27
@BrewTestBot BrewTestBot removed the missing license Formula has a missing license which should be added label Jan 5, 2021
@carlocab
carlocab force-pushed the opencascade-tcl-tk branch 3 times, most recently from 5c5ec77 to a049d7d Compare January 6, 2021 00:14
@andysan

andysan commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

I ran into an issue requiring the same fix and was just about to post this branch https://github.com/andysan/homebrew-core/commits/fixes_big_sur_opencascade to address it when I came across this PR. This should solve the issue TCL/TK issue ran into.

I also had weird runtime linking issues running the tests on an Apple Silicon-based machine. I have a change on my OpenCASCADE fixup branch that might be worth cherry-picking to make the formula test correctly on such machines.

@andysan andysan mentioned this pull request Jan 6, 2021
5 tasks done
@carlocab

carlocab commented Jan 6, 2021 •

Copy link
Copy Markdown
Member Author

Thanks, I actually eventually got to the exact same fix as you did here: andysan@973c672

Was just about to push it, though I was trying to experiment with using fewer flags. Eventually settled on using all of them.

@carlocab
carlocab force-pushed the opencascade-tcl-tk branch from a049d7d to aeb928d Compare January 6, 2021 00:45
@carlocab

carlocab commented Jan 6, 2021

Copy link
Copy Markdown
Member Author

freeimage still has no ARM bottle, though, so that's probably blocking for this formula to get an ARM bottle.

@BrewTestBot

Copy link
Copy Markdown
Contributor

馃 A scheduled task has triggered a merge.

@carlocab
carlocab deleted the opencascade-tcl-tk branch January 6, 2021 14:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 6, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no ARM bottle Formula has no ARM bottle outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants