Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halide 10.0.0 (new formula) #61246

Closed
wants to merge 1 commit into from
Closed

halide 10.0.0 (new formula) #61246

wants to merge 1 commit into from

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Sep 17, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Notes

  • Requires LLVM 9+ (fails with uses_from_macos suggested by --new-formula audit)
  • The license file lists two additional licenses (one for apps/bgu and another for apps/support/cmdline.h) but neither are installed with make install. We could delete these files if that's a good practice, or use license all_of: [...].

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Sep 17, 2020
@ankane
Copy link
Contributor Author

ankane commented Sep 17, 2020

All three failures due to new formula audit:

  * Dependency 'llvm' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankane ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@ankane
Copy link
Contributor Author

ankane commented Oct 1, 2020

Thanks @SMillerDev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants