krb5: add a fix for broken configure test#58191
Merged
claui merged 1 commit intoHomebrew:masterfrom Jul 19, 2020
Merged
Conversation
9 tasks
claui
reviewed
Jul 19, 2020
claui
approved these changes
Jul 19, 2020
Contributor
|
The CI failures only affect Both |
Contributor
|
Thanks @mistydemeo! 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This fixes krb5 on macOS 11, both ARM and x86_64. It turns out that clang's new pickiness about calling functions without their header definitions broke this test. The test is actually testing destructor attributes, and for convenience is using the C
unlinkfunction. That is defined inunistd.h, but the configure test doesn't#includethis header.I'll be submitting an upstream fix as well, but this
inreplacefix gets us going.