Conversation
|
This is one of the reasons why we don't usually accept PR patches. A stable commit patch URL should be used instead. |
|
@Bo98, do you want me to change this? |
This replaces the three unmerged PR patches with a hosted formula patch. This includes the following upstream pull requests: - python/cpython#20171, "Fix _tkinter use" (prerequisite for 21249) - python/cpython#21114, "Support arm64 in Mac/Tools/pythonw" - python/cpython#21224, "allow python to build for macosx-11.0-arm64" - python/cpython#21249, "ctypes fixes for arm64 Mac OS" See also: - Homebrew/formula-patches#292
a5d44ee to
49eb19c
Compare
|
Thanks @xvilo. I replaced the URL with a hosted patch with the changes rolled into one file. |
|
Thanks @claui for the fast fix! Would not have done it this way ✨ |
|
Perhaps no longer required since #57934 has been merged. |
|
@miccal Thanks. Either it’s no longer needed, or we have to redo the patch. |
|
Only one of the mentioned PRs have been merged, and I think it hasn't been backported to 3.8. |
|
You’re correct @Bo98. I just rebased on 3.8.4 locally and tested the changes. |
|
I’ve skimmed through the 10.14 errors:
Please tick boxes where we’re ok with the failure. |
|
Since the changes here are in a block that does not even get executed on any of the CIs since none are running ARM, it should be ok to merge. |
|
|
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?It appears the checksum is incorrect, on Big Sur you will get a
checksum mismatch. I have checked on multiple devices:
curl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 > test.patch && shasum -a 256 test.patchcurl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 > test.patch && shasum -a 256 test.patchcurl -L https://github.com/python/cpython/pull/21249.patch\?full_index\=1 | sha256sumThis should be the 'correct' checksum. Please let me know if
I might have missed something.
Current error output when installing Make: