Patch Perl for macOS 11.x#57580
Patch Perl for macOS 11.x#57580SeekingMeaning merged 5 commits intoHomebrew:masterfrom BytesGuy:perl-macos11
Conversation
|
Makes sense. Let's give upstream a couple days to give comment first (PR diff URLs aren't stable as they change if any changes to the PR is made). |
Ok, good call 🙂 Will follow up on this when my PR is reviewed! Meanwhile this might help anyone who is blocked. I wonder how many of these kinds of issues we will see since being bumped to |
|
We won’t be enabling
|
|
I think this is the only instance of an issue with the 11.0 version number so far. I’ll be following up on the PR to the Perl repo later, been offline for a few days so just catching up with things. |
Formula/perl.rb
Outdated
| url "https://github.com/Perl/perl5/pull/17946.diff?full_index=1" | ||
| sha256 "677a6e63412a4cfd2dc1fe16ccca53d789be5ac1acfb5ebb3130c40b51e5e94a" |
There was a problem hiding this comment.
Please either use a commit URL or submit this to formula-patches. Note that the sha256 hash is already mismatched as you've pushed additional commits to that branch.
There was a problem hiding this comment.
@jonchang Unless it's urgent we can wait until the upstream PR is merged in and use that as the patch, otherwise it just means updating the formula again. I'm pushing changes to the upstream PR shortly so hopefully it will be good enough to get merged in to resolve the issue for now.
There was a problem hiding this comment.
Just pushed changes so let's hold for a few days to see what happens. If this doesn't get merged soon I'll just create a formula-patch as it will be easier to manage 👍
|
@claui @jonchang I’ve opened Homebrew/formula-patches#293 so we can resolve this without waiting for the PR to be merged into Perl, it is taking some time! |
Thanks! Merged the formula patch. |
Thanks 🙂 Just updated the formula to point to that patch, should be all good now! |
It’s helpful to have the word `remove` in the comment for temporary patches because: 1. it’s a call to action (which helps with upkeep); and 2. whenever we want to prune outdated temporary patches, we have something to grep for.
SeekingMeaning
added
ready to merge
|
I just wanted to ask. |
6 participants
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Perl will currently fail to build (Intel and Apple Silicon) as it is expecting to match the product version
10.x, whereas Big Sur has been bumped to11.0. This is a temporary patch until support is available upstream (PR created: Perl/perl5#17946)