Fix for nettle on Apple Silicon#57455
Merged
mistydemeo merged 4 commits intoHomebrew:masterfrom Jul 20, 2020
BytesGuy:nettle-arm
Merged
Fix for nettle on Apple Silicon#57455mistydemeo merged 4 commits intoHomebrew:masterfrom BytesGuy:nettle-arm
mistydemeo merged 4 commits intoHomebrew:masterfrom
BytesGuy:nettle-arm
Conversation
9 tasks
Contributor
Author
|
Note: this relies on GMP being fixed by #57315 |
SMillerDev
reviewed
Jul 5, 2020
BytesGuy
changed the title
Contributor
Author
|
Looks like the test failure is related to a different formula |
mistydemeo
suggested changes
Jul 17, 2020
mistydemeo
suggested changes
Jul 18, 2020
Contributor
mistydemeo
left a comment
mistydemeo
left a comment
There was a problem hiding this comment.
Thanks! As you mentioned, the test failures are unrelated. Just one more comment and I think we're good here.
mistydemeo
approved these changes
Jul 19, 2020
Contributor
|
Thank you! Your contribution is greatly appreciated, and the assistance getting things going on Apple Silicon is a big help. |
Contributor
Author
Thanks :) Sorry for the late response, I have been offline for a few days! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Disabling the attempt to build with assembly optimisations which causes a failure on Apple Silicon. This is very much a temporary fix for now as it will cause some performance hit. This should get it working until arm64 support is available upstream.