Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin rtv dependencies #55974

Closed
wants to merge 1 commit into from
Closed

Conversation

dtrodrigues
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@dtrodrigues
Copy link
Member Author

Per michael-lazar/rtv#696, the project is no longer maintained.

@dtrodrigues
Copy link
Member Author

There have been over 5k downloads in the last year since the project stopped actively being maintained: https://formulae.brew.sh/formula/rtv

@SMillerDev
Copy link
Member

Can you mark it as deprecated since the maintenance stop?

Formula/rtv.rb Outdated
@@ -15,14 +15,62 @@ class Rtv < Formula
sha256 "a12678c3f7c95c3d45c2e631fda28d1da29fd6768f8dcce235b3599f580e264b" => :high_sierra
end

deprecate! :date => "June 2, 2019"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the other deprecation statements within Homebrew are in "Month DD, YYYY" format. Should they be changed as well? The ambiguity referred to in the comic primarily comes when the month is not spelled out and/or the year is represented by 2 digits, but there isn't a different interpretation for the format currently used. I can make the change if that's what's desired though.

 ~/homebrew-core/Formula (master) $ grep deprecate *rb  | grep date
elasticsearch@2.4.rb:  deprecate! :date => "February 28, 2018"
elasticsearch@5.6.rb:  deprecate! :date => "March 11, 2019"
go@1.10.rb:  deprecate! :date => "February 25, 2019"
go@1.11.rb:  deprecate! :date => "September 3, 2019"
go@1.12.rb:  deprecate! :date => "February 25, 2020"
go@1.9.rb:  deprecate! :date => "August 4, 2018"
gradio.rb:  deprecate! :date => "November 16, 2019"
kibana@5.6.rb:  deprecate! :date => "March 11, 2019"
php@7.2.rb:  deprecate! :date => "November 30, 2020"
php@7.3.rb:  deprecate! :date => "December 6, 2021"
postgresql@9.4.rb:  deprecate! :date => "February 13, 2020"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ISO 8601 for this PR. No need to change the other formulae. I'll open a PR to add a brew style Rubocop to enforce ISO 8601 date format, unless you'd like to do that, in which case, have at it!

SMillerDev
SMillerDev previously approved these changes Jun 10, 2020
@SMillerDev SMillerDev dismissed their stale review June 10, 2020 07:10

Missed the CI state

SMillerDev
SMillerDev previously approved these changes Jun 10, 2020
@SMillerDev SMillerDev requested a review from sjackman June 10, 2020 18:59
sjackman
sjackman previously approved these changes Jun 11, 2020
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ bottle publish failure.

@BrewTestBot BrewTestBot dismissed stale reviews from SMillerDev and sjackman June 11, 2020 23:06

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @SMillerDev has triggered a merge.

@dtrodrigues dtrodrigues deleted the rtv-pinned branch June 23, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants