-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uses_from_macos
to formulae, part 1 (a-j)
#41435
Conversation
With macOS Catalina approaching, which contains both Python 2 and 3… what does this mean? Does it mean “uses Python 2 on all macOS versions, even when Python 3 is there?” Something else?
Imagine formula X has |
It means, "use system Python 2 on all versions".
Yes, I'll write an audit to check for linkages and that sort of thing.
Then it should be changed to |
But do we have checks that say “this is not actually used anymore”? If not, these lines will bitrot. |
Yes, I'll write an audit to check for linkages and that sort of thing. Degraded functionality could be tested via |
Audit: Homebrew/brew#6265 |
Thanks @jonchang |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?c.f. Homebrew/brew#6150
Note that there are many instances in linuxbrew-core where
uses_from_macos
is (I believe) used improperly. For example,uses_from_macos "python"
is incorrect because macOS does not provide a Python 3 installation. Something to think about for a follow up issue.I'll open a pull request for part 2 once this is merged.