Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-machine-driver-xhyve 0.2.3 #3638

Closed

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Aug 5, 2016

Created with brew bump-formula-pr.

@zchee
Copy link
Contributor

zchee commented Aug 5, 2016

@ilovezfs Thanks upgrade :)

But current version(v0.2.3) needs

diff --git a/Formula/docker-machine-driver-xhyve.rb b/Formula/docker-machine-driver-xhyve.rb
index 94b45e5..67a9e6e 100644
--- a/Formula/docker-machine-driver-xhyve.rb
+++ b/Formula/docker-machine-driver-xhyve.rb
@@ -27,10 +27,10 @@ class DockerMachineDriverXhyve < Formula
       if build.head?
         git_hash = `git rev-parse --short HEAD --quiet`.chomp
         git_hash = "HEAD-#{git_hash}"
-        ENV["CGO_LDFLAGS"] = "#{build_root}/vendor/build/lib9p/lib9p.a -L#{build_root}/vendor/lib9p"
-        ENV["CGO_CFLAGS"] = "-I#{build_root}/vendor/lib9p"
-        system "make", "lib9p"
       end
+      ENV["CGO_LDFLAGS"] = "#{build_root}/vendor/build/lib9p/lib9p.a -L#{build_root}/vendor/lib9p"
+      ENV["CGO_CFLAGS"] = "-I#{build_root}/vendor/lib9p"
+      system "make", "lib9p"
       system "go", "build", "-x", "-o", bin/"docker-machine-driver-xhyve",
       "-ldflags",
       "'-w -s'",

What should I do? Should I post a new PR?

@DomT4 DomT4 added the needs response Needs a response from the issue/PR author label Aug 6, 2016
@MikeMcQuaid
Copy link
Member

@zchee Feel free to create a new PR 👍

@zchee
Copy link
Contributor

zchee commented Aug 8, 2016

@MikeMcQuaid got it, will send a new pull request.

BTW, Is there problem in posted diff?
I was tried brew install for test, but can't installing because occur you use Sierra(? I forgot) error.

@ghost ghost removed the needs response Needs a response from the issue/PR author label Aug 8, 2016
@MikeMcQuaid
Copy link
Member

@zchee Looks fine to me.

@zchee
Copy link
Contributor

zchee commented Aug 8, 2016

@MikeMcQuaid OK, thanks :)

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Aug 8, 2016

Yes, I know that's the required change as it's already in the head spec and I'd already tested that with the new version, but just hadn't gotten around to updating this PR yet but I guess I'll close it if someone else is now working on it ...

@zchee
Copy link
Contributor

zchee commented Aug 8, 2016

@MikeMcQuaid @ilovezfs I created new pull request. PTAL.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants