-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-machine-driver-xhyve 0.2.3 #3638
docker-machine-driver-xhyve 0.2.3 #3638
Conversation
@ilovezfs Thanks upgrade :) But current version(v0.2.3) needs diff --git a/Formula/docker-machine-driver-xhyve.rb b/Formula/docker-machine-driver-xhyve.rb
index 94b45e5..67a9e6e 100644
--- a/Formula/docker-machine-driver-xhyve.rb
+++ b/Formula/docker-machine-driver-xhyve.rb
@@ -27,10 +27,10 @@ class DockerMachineDriverXhyve < Formula
if build.head?
git_hash = `git rev-parse --short HEAD --quiet`.chomp
git_hash = "HEAD-#{git_hash}"
- ENV["CGO_LDFLAGS"] = "#{build_root}/vendor/build/lib9p/lib9p.a -L#{build_root}/vendor/lib9p"
- ENV["CGO_CFLAGS"] = "-I#{build_root}/vendor/lib9p"
- system "make", "lib9p"
end
+ ENV["CGO_LDFLAGS"] = "#{build_root}/vendor/build/lib9p/lib9p.a -L#{build_root}/vendor/lib9p"
+ ENV["CGO_CFLAGS"] = "-I#{build_root}/vendor/lib9p"
+ system "make", "lib9p"
system "go", "build", "-x", "-o", bin/"docker-machine-driver-xhyve",
"-ldflags",
"'-w -s'", What should I do? Should I post a new PR? |
@zchee Feel free to create a new PR 👍 |
@MikeMcQuaid got it, will send a new pull request. BTW, Is there problem in posted diff? |
@zchee Looks fine to me. |
@MikeMcQuaid OK, thanks :) |
Yes, I know that's the required change as it's already in the head spec and I'd already tested that with the new version, but just hadn't gotten around to updating this PR yet but I guess I'll close it if someone else is now working on it ... |
@MikeMcQuaid @ilovezfs I created new pull request. PTAL. |
Created with
brew bump-formula-pr
.