improve instructions in CONTRIBUTING.md

[DanGrayson]

See the discussion at #35920.

[SMillerDev]

I think this is already better than before but I think there's still some improvements to be made.

[DanGrayson]

Thanks for the feedback, now take a look.

[SMillerDev]

Looks good to me.

[DanGrayson]

Thanks. Perhaps you could mark your review so it shows the changes are now accepted.

[DanGrayson]

Okay, I'll put the colon back in, on Tuesday.

…

On Thu, Jan 17, 2019, 23:56 Sean Molenaar ***@***.*** wrote: ***@***.**** commented on this pull request. ------------------------------ In CONTRIBUTING.md <#36082 (comment)> : > +brew audit --strict foo +``` + +After testing, if you think it is needed to force the corresponding bottles to be +rebuilt and redistributed, add a line of the form `revision 1` to the formula, +or add 1 to the revision number already present. + +If you are not already well versed in the use of `git`, then you may learn +about it from the introduction at +https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request and then proceed as +follows: + +* run `brew edit foo` and make edits +* leave the section `bottle do ... end` unchanged +* test your changes using the commands listed above +* run `git commit` with message formatted `foo <insert details>` I just checked again and the bot does use it. Sorry about that, I guess I have to change my own habbit too then 😅. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#36082 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqvRJfBMa9ohl6EZeQzG_u6DEAakMfSks5vEWIrgaJpZM4aD71F> .

[claui]

Thanks @DanGrayson! Apologies for the confusion.

[SMillerDev]

@claui ready to merge?

[claui]

@SMillerDev I made a change in order to clarify the commit messages. Mind reviewing my change one last time before we merge?

[SMillerDev]

Looks good to me.

[DanGrayson]

Fine with me.

[claui]

Thanks for your contribution @DanGrayson! 🍻