crystal 1.21.0#293531
Conversation
github-actions
Bot
added
the
bump-formula-pr
6fcbf9a to
d1b2a06
Compare
|
The failure comes from amber, which builds an old and incompatible version of ameba as dependency for no reason. Not sure what the homebrew policy is for this kind of thing, but it's a pity that a useless incompatibility blocks upgrading the crystal package. A patch could be upgrading the ameba dependency to latest master, or skipping to build ameba in amber setup. It's a development dependency and completely useless when only installing the package. |
With the latest Crystal update to 1.21.0 the project fails to build
`ameba` dependency. Here's the error that happens after running
`shards install`:
```
Failed postinstall of ameba on shards build -Dpreview_mt:
I: Dependencies are satisfied
I: Building: ameba
E: Error target ameba failed to compile:
The 'preview_mt' flag is deprecated. Resize the default execution context, or start additional contexts instead.
In src/ameba/rule/base.cr:117:34
117 | source.add_issue(self, {{ *args }}, {{ **kwargs }}) {{ block }}
^
Warning: Deprecated use of splat operator. Use `#splat` instead
In src/ameba/rule/base.cr:117:48
117 | source.add_issue(self, {{ *args }}, {{ **kwargs }}) {{ block }}
^
Warning: Deprecated use of double splat operator. Use `#double_splat` instead
A total of 3 warnings were found.
Showing last frame. Use --error-trace for full trace.
In src/ameba/tokenizer.cr:88:15
88 | lexer.next_string_array_token
^----------------------
Error: undefined method 'next_string_array_token' for Crystal::Lexer (compile-time type is Crystal::Lexer+)
```
This was fixed by the upstream but there's no tagged release
with the patch yet, so switching to `master` branch
References:
- crystal-ameba/ameba#823
- Homebrew/homebrew-core#293531
Signed-off-by: botantony <antonsm21@gmail.com>
carlocab
added
the
CI-no-fail-fast-deps
carlocab
left a comment
carlocab
left a comment
There was a problem hiding this comment.
We can ignore the amber failure for now and fix/deprecate it separately.
|
Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
github-actions
Bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
4 participants
Created by
brew bumpCreated with
brew bump-formula-pr.resourceblocks have been checked for updates.