Draft
Conversation
Contributor
Author
vouch is 21 days old. should i wait another 9 days or can we already get a first round of reviews? |
SMillerDev
reviewed
Feb 25, 2026
Comment on lines
+14
to
+22
| # Wrapper script based on upstream's setup-vouch action: | ||
| # https://github.com/mitchellh/vouch/blob/c6d80ead49839655b61b422700b7a3bc9d0804a9/action/setup-vouch/action.yml | ||
| (buildpath/"vouch-wrapper").write <<~BASH | ||
| #!/usr/bin/env bash | ||
| cmd='' | ||
| for a in "$@"; do cmd="$cmd $(printf '%q' "$a")"; done | ||
| if [ $# -eq 0 ]; then cmd='vouch main'; fi | ||
| exec nu --no-config-file -c "use '#{opt_share}/nushell/lib/vouch' *; $cmd" | ||
| BASH |
Member
There was a problem hiding this comment.
We should not maintain our own script. If upstream does not ship one, neither should we.
Contributor
Author
There was a problem hiding this comment.
they provide one by inlining it into a github workflow, just not directly in the repo as a file: https://github.com/mitchellh/vouch/blob/c6d80ead49839655b61b422700b7a3bc9d0804a9/action/setup-vouch/action.yml#L30-L40
i can try to create a pr upstream that pushes this script into a separate file (plus minus some nu lib dir replacements probably). would it be acceptable then?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?vouch is younger than 30 days so the
brew audit --new vouchtest is failing