Skip to content

vouch 1.4.2 (new formula)#269267

Draft
pavelzw wants to merge 1 commit intoHomebrew:mainfrom
pavelzw:vouch
Draft

vouch 1.4.2 (new formula)#269267
pavelzw wants to merge 1 commit intoHomebrew:mainfrom
pavelzw:vouch

Conversation

@pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Feb 24, 2026

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

vouch is younger than 30 days so the brew audit --new vouch test is failing


  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.


@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Feb 24, 2026
@pavelzw
Copy link
Contributor Author

pavelzw commented Feb 24, 2026

Full audit --formula vouch --online --new output
  vouch
    * GitHub repository too new (<30 days old)
  Error: 1 problem in 1 formula detected.

vouch is 21 days old. should i wait another 9 days or can we already get a first round of reviews?

@pavelzw pavelzw marked this pull request as ready for review February 24, 2026 23:33
Comment on lines +14 to +22
# Wrapper script based on upstream's setup-vouch action:
# https://github.com/mitchellh/vouch/blob/c6d80ead49839655b61b422700b7a3bc9d0804a9/action/setup-vouch/action.yml
(buildpath/"vouch-wrapper").write <<~BASH
#!/usr/bin/env bash
cmd=''
for a in "$@"; do cmd="$cmd $(printf '%q' "$a")"; done
if [ $# -eq 0 ]; then cmd='vouch main'; fi
exec nu --no-config-file -c "use '#{opt_share}/nushell/lib/vouch' *; $cmd"
BASH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not maintain our own script. If upstream does not ship one, neither should we.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they provide one by inlining it into a github workflow, just not directly in the repo as a file: https://github.com/mitchellh/vouch/blob/c6d80ead49839655b61b422700b7a3bc9d0804a9/action/setup-vouch/action.yml#L30-L40

i can try to create a pr upstream that pushes this script into a separate file (plus minus some nu lib dir replacements probably). would it be acceptable then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelzw pavelzw marked this pull request as draft February 25, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants