Skip to content

Conversation

@branchvincent
Copy link
Member

cfv: migrate to python@3.14

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Oct 11, 2025
@daeho-ro
Copy link
Member

  Traceback (most recent call last):
    File "/opt/homebrew/Cellar/cfv/3.1.0/bin/cfv", line 3, in <module>
      from cfv.common import main
    File "/opt/homebrew/Cellar/cfv/3.1.0/libexec/lib/python3.14/site-packages/cfv/common.py", line 49, in <module>
      from cfv import ui
    File "/opt/homebrew/Cellar/cfv/3.1.0/libexec/lib/python3.14/site-packages/cfv/ui.py", line 10, in <module>
      from cfv import term
    File "/opt/homebrew/Cellar/cfv/3.1.0/libexec/lib/python3.14/site-packages/cfv/term.py", line 28, in <module>
      scrwidth = getscrwidth()
    File "/opt/homebrew/Cellar/cfv/3.1.0/libexec/lib/python3.14/site-packages/cfv/term.py", line 16, in getscrwidth
      h, w = struct.unpack('h h', ioctl(tty.fileno(), TIOCGWINSZ, '\0' * struct.calcsize('h h')))
                                  ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  SystemError: buffer overflow

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Oct 11, 2025
Copilot AI review requested due to automatic review settings October 17, 2025 05:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the cfv formula from Python 3.13 to Python 3.14 and includes a patch to fix a buffer overflow error in the term.py file.

Key changes:

  • Updated Python dependency from python@3.13 to python@3.14
  • Added an inreplace block to patch lib/cfv/term.py to resolve a SystemError buffer overflow issue

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@daeho-ro daeho-ro added ready to merge PR can be merged once CI is green and removed test failure CI fails while running the test-do block labels Oct 17, 2025
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 18, 2025
@BrewTestBot BrewTestBot enabled auto-merge October 18, 2025 15:06
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 18, 2025
Merged via the queue into Homebrew:main with commit 25aedd5 Oct 18, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue python-3.14-migration ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants