Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 21, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Makefile already sets ACL2 at https://github.com/acl2/acl2/blob/master/GNUmakefile#L166-L169

PREFIXsaved_acl2 := ${PREFIX}saved_acl2${ACL2_SUFFIX}
PREFIXosaved_acl2 := ${PREFIX}osaved_acl2${ACL2_SUFFIX}

ACL2 ?= $(ACL2_WD)/${PREFIXsaved_acl2}

And setting ACL2_PAR handles to suffix at https://github.com/acl2/acl2/blob/master/GNUmakefile#L150-L151

ifdef ACL2_PAR
	ACL2_SUFFIX := $(ACL2_SUFFIX)p

write_env_script can also be used instead of writing out shell scripts.

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Sep 21, 2025
@cho-m cho-m force-pushed the acl2-updates branch 2 times, most recently from 28b8338 to e2cb855 Compare September 21, 2025 01:30
@cho-m cho-m changed the title acl2: improve formula readability acl2: improve formula readability, use saved_acl2 scripts Sep 21, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2025
Merged via the queue into main with commit da5b4e1 Sep 21, 2025
28 checks passed
@BrewTestBot BrewTestBot deleted the acl2-updates branch September 21, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants