Skip to content

Conversation

@Dimi1010
Copy link
Contributor

@Dimi1010 Dimi1010 commented Aug 16, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The PcapPlusPlus unit tests are not exported or used during the install process, so building them is unnecessary.

The pcapplusplus unit tests are not exported or used during the install process, so building them is unnessesary.
@Dimi1010 Dimi1010 marked this pull request as ready for review August 16, 2025 08:57
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Aug 16, 2025
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added this pull request to the merge queue Aug 16, 2025
Merged via the queue into Homebrew:main with commit 5c3dde0 Aug 16, 2025
29 checks passed
@Dimi1010 Dimi1010 deleted the fm/pcapplusplus-25.05-disable-tests branch August 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants