-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
periphery 2.21.2 (new formula) #202049
base: master
Are you sure you want to change the base?
periphery 2.21.2 (new formula) #202049
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
20dc071
to
6b316c9
Compare
@ileitch since periphery needs xcodeproject, maybe you should drop the linux support for the formula? |
80a3333
to
4507cfc
Compare
It also works on Linux with just SPM, but I've had to disable the formula test on Linux because the test image appears to be missing |
4507cfc
to
2c95afb
Compare
Sounds good 👍 |
Formula/p/periphery.rb
Outdated
end | ||
|
||
depends_on xcode: ["15.4", :build] | ||
depends_on macos: :sonoma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would swift 6 work for ventura?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped it to :ventura
as that's the minimum version supported by the Package.swift.
2c95afb
to
1a42573
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?