Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

periphery 2.21.2 (new formula) #202049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ileitch
Copy link

@ileitch ileitch commented Dec 21, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue labels Dec 21, 2024
Formula/p/periphery.rb Outdated Show resolved Hide resolved
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@ileitch ileitch force-pushed the add-periphery branch 7 times, most recently from 20dc071 to 6b316c9 Compare December 21, 2024 18:01
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 22, 2024
@chenrui333
Copy link
Member

@ileitch since periphery needs xcodeproject, maybe you should drop the linux support for the formula?

@ileitch ileitch force-pushed the add-periphery branch 7 times, most recently from 80a3333 to 4507cfc Compare December 26, 2024 14:11
@ileitch
Copy link
Author

ileitch commented Dec 26, 2024

@ileitch since periphery needs xcodeproject, maybe you should drop the linux support for the formula?

It also works on Linux with just SPM, but I've had to disable the formula test on Linux because the test image appears to be missing libIndexStore.so. Hopefully that's acceptable 🤞.

Formula/p/periphery.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

@ileitch since periphery needs xcodeproject, maybe you should drop the linux support for the formula?

It also works on Linux with just SPM, but I've had to disable the formula test on Linux because the test image appears to be missing libIndexStore.so. Hopefully that's acceptable 🤞.

Sounds good 👍

end

depends_on xcode: ["15.4", :build]
depends_on macos: :sonoma
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would swift 6 work for ventura?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped it to :ventura as that's the minimum version supported by the Package.swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants