Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib-ng-compat 2.2.2 (new formula) #199495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

zlib-ng-compat 2.2.2 (new formula) #199495

wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 29, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Potential formula for providing zlib-ng with the zlib compatible API. Current zlib-ng formula is built with separate API for non-conflicting installation.

In future, could follow Fedora and use this as default zlib (https://fedoraproject.org/wiki/Changes/ZlibNGTransition) to provide a more optimized alternative for Linux users.

Though transition may want to wait for some other distros to adopt (Arch Linux recently introduced https://archlinux.org/packages/extra/x86_64/zlib-ng-compat/ so they could go this route).

May also be possible for Linux users to inject this via one of the supported ld.so environment variables as mentioned in https://github.com/zlib-ng/zlib-ng?tab=readme-ov-file#install

For Linux distros, an alternative way to use zlib-ng (if compiled in zlib-compat mode) instead of zlib, is through the use of the LD_PRELOAD environment variable. If the program is dynamically linked with zlib, then the program will temporarily attempt to use zlib-ng instead, without risking system-wide instability.

Less useful on macOS as we typically use system zlib, though we could consider it for MySQL which forces us to use a newer version of zlib.

@cho-m cho-m added the maintainer feedback Additional maintainers' opinions may be needed label Nov 29, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 29, 2024
@cho-m cho-m marked this pull request as ready for review November 29, 2024 17:18
@chenrui333 chenrui333 requested a review from a team December 8, 2024 02:53
Comment on lines +9 to +11
livecheck do
formula "zlib-ng"
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it to synced_versions_formulae.json (with zlib-ng)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants