Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfreehand: fix build as boost is no longer runtime dep #198142

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 18, 2024

After removing boost runtime dependency from librevenge, the build fails without icu4c@76 as configure checks for it via pkg-config

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

After removing `boost` runtime dependency from `librevenge`, the build
fails without `icu4c@76` as configure checks for it via pkg-config
@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 18, 2024
@github-actions github-actions bot added boost Boost use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Nov 18, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit b3dac84 Nov 18, 2024
22 checks passed
@chenrui333 chenrui333 deleted the libfreehand-fix-build branch November 18, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles icu4c ICU use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants