dpcmd: Include the config file for the program to work #197671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, the maintainer had just created a new release, should I update it in this same pull request? Or should I create another one for it? |
carlocab
reviewed
Nov 14, 2024
Just update it here, I think. You can just amend your existing commit for it. |
github-actions
bot
added
the
autosquash
superjeng1
force-pushed
the
dpcmd
branch
2 times, most recently
from
18507e3
to
90329a2
Compare
github-actions
bot
removed
the
autosquash
carlocab
reviewed
Nov 14, 2024
superjeng1
force-pushed
the
dpcmd
branch
2 times, most recently
from
7a7ac8e
to
2e2e8bf
Compare
|
When would the bottles be rebuilt? Do I have to do anything? |
|
@superjeng1 It will be done automatically after the review :) |
|
Can someone please review the changes? Thanks! |
Also, include the config file for it to work: - dpcmd requires the `ChipInfoDb.dedicfg` file to function properly. - Bumped dpcmd version to V1.14.21 for macOS compatibility.
|
Looks like all tests has passed, please go ahead with the merge. Thanks! |
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This file is required for the program to actually work, so I added it in.
On macOS, it would require this pull request to work. It was already merged, but the maintainer has not made a release since then. But this should still be added in.