-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dagger-io: 0.14.0 python sdk (new formula) #197403
base: master
Are you sure you want to change the base?
dagger-io: 0.14.0 python sdk (new formula) #197403
Conversation
e63573c
to
2446d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is sdk, why not just do pip install?
Doesn't play nicely with brew installed dagger for dagger run python call which requires the sdk if developing that way |
can you add test for dagger to show how it is being used? |
@chenrui would need to add dependency on dagger which would get out of the scope of this commit Importing the module as seen in the test is effectively the usage |
you can add that dependency in this PR, I would like to see how it looks like (also do you have any docs for such thing?) |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@clintonsteiner this sounds like a dagger bug to me (as a maintainer of dagger) - the |
Thanks for the response, I'll try to look into it from that side and see what I find out |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?