Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dagger-io: 0.14.0 python sdk (new formula) #197403

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clintonsteiner
Copy link
Contributor

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you ensured that your commits follow the commit style guide?
  • [ x] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [ x] Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [ x] Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • [ x] Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 12, 2024
@clintonsteiner clintonsteiner force-pushed the addDaggerIoPythonClient branch from e63573c to 2446d7e Compare November 12, 2024 03:41
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is sdk, why not just do pip install?

@clintonsteiner
Copy link
Contributor Author

since this is sdk, why not just do pip install?

Doesn't play nicely with brew installed dagger for dagger run python call which requires the sdk if developing that way

@chenrui333
Copy link
Member

since this is sdk, why not just do pip install?

Doesn't play nicely with brew installed dagger for dagger run python call which requires the sdk if developing that way

can you add test for dagger to show how it is being used?

@clintonsteiner
Copy link
Contributor Author

@chenrui would need to add dependency on dagger which would get out of the scope of this commit

Importing the module as seen in the test is effectively the usage

@chenrui333
Copy link
Member

@chenrui would need to add dependency on dagger which would get out of the scope of this commit

you can add that dependency in this PR, I would like to see how it looks like (also do you have any docs for such thing?)

@chenrui333 chenrui333 marked this pull request as draft November 13, 2024 20:26
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Dec 5, 2024
@jedevc
Copy link
Contributor

jedevc commented Dec 11, 2024

Doesn't play nicely with brew installed dagger for dagger run python call which requires the sdk if developing that way

@clintonsteiner this sounds like a dagger bug to me (as a maintainer of dagger) - the dagger run ... command should pick up on pip packages just as if you ran ... directly - if it doesn't it sounds like something's wrong - that's not by design.

@github-actions github-actions bot removed the stale No recent activity label Dec 11, 2024
@clintonsteiner
Copy link
Contributor Author

Doesn't play nicely with brew installed dagger for dagger run python call which requires the sdk if developing that way

@clintonsteiner this sounds like a dagger bug to me (as a maintainer of dagger) - the dagger run ... command should pick up on pip packages just as if you ran ... directly - if it doesn't it sounds like something's wrong - that's not by design.

Thanks for the response, I'll try to look into it from that side and see what I find out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants