Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphviz: for stopping errors with --with-bindings #19709

Merged
merged 3 commits into from
Oct 23, 2017
Merged

graphviz: for stopping errors with --with-bindings #19709

merged 3 commits into from
Oct 23, 2017

Conversation

s172262
Copy link
Contributor

@s172262 s172262 commented Oct 21, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This PR is reopening #19128.

for stopping errors with --with-bindings
@@ -58,6 +58,10 @@ def install
inreplace "lib/sfio/features/sfio", "lib qfrexp\nlib qldexp\n", ""

if build.with? "bindings"
# The following setting makes to find "python.h".
# https://github.com/Homebrew/homebrew-core/issues/19110
ENV["PYTHON_INCLUDES"] = "-I" << `python -c "from __future__ import print_function;import sysconfig; print (sysconfig.get_path('include'))"`.chomp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here if it cannot find it automatically. This shouldn't be necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without Homebrew's python:

$ python -c "from __future__ import print_function;import sysconfig; print (sysconfig.get_path('include'))"
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7

I understand this is too bad.

@s172262
Copy link
Contributor Author

s172262 commented Oct 23, 2017

I hasten to repair PHP's errors.

@@ -71,6 +71,7 @@ def install
--prefix=#{prefix}
--without-qt
--with-quartz
--enable-php=no
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does --disable-php work instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ther is no different --enable-php=no and --disable-php.

==> ./configure --disable-debug --disable-dependency-tracking --prefix=/usr/local/Cellar/graphviz/2.40.1 --without-qt --with-quartz --enable-php=no --with-gts --without-rsvg
----------------------------------------------------------------

graphviz-2.40.1 will be compiled with the following:

options:
  cgraph:        Yes (always enabled)
  digcola:       Yes
  expat:         Yes
  fontconfig:    Yes
  freetype:      Yes
  glut:          Yes
  ann:           No (ANN library not available)
  gts:           Yes
  ipsepcola:     No (disabled by default - C++ portability issues)
  ltdl:          Yes
  ortho:         Yes
  sfdp:          Yes
  shared:        Yes
  static:        No (disabled by default)
  qt:            No (disabled)
  x:             Yes

commands:
  dot:           Yes (always enabled)
  neato:         Yes (always enabled)
  fdp:           Yes (always enabled)
  circo:         Yes (always enabled)
  twopi:         Yes (always enabled)
  gvpr:          Yes (always enabled)
  gvmap:         Yes (always enabled)
  lefty:         Yes
  smyrna:        No (disabled by default - experimental)
  gvedit:        No (disabled)

plugin libraries:
  dot_layout:    Yes (always enabled)
  neato_layout:  Yes (always enabled)
  core:          Yes (always enabled)
  devil:         No (missing library)
  gd:            Yes
  gdiplus:       No (disabled by default - Windows only)
  gdk:           
  gdk_pixbuf:    No (gdk_pixbuf library not available)
  ghostscript:   Yes
  glitz:         No (disabled by default - incomplete)
  gtk:           No (gtk library not available)
  lasi:          No (lasi library not available)
  ming:          No (disabled by default - incomplete)
  pangocairo:    Yes
  poppler:       No (poppler library not available)
  quartz:        Yes
  rsvg:          No (disabled)
  visio:         No (disabled by default - experimental)
  webp:          No (disabled by default - experimental)
  xlib:          Yes

language extensions:
  gv_sharp:      No (mcs not available)
  gv_go:         No (disabled by default - experimental)
  gv_guile:      No (guile not available)
  gv_io:         No (disabled by default - no swig support yet)
  gv_java:       Yes
  gv_lua:        No (lua not available)
  gv_ocaml:      No (ocaml not available)
  gv_perl:       Yes
  gv_php:        No (disabled)
  gv_python:     Yes
  gv_python23:   No (disabled by default - for multiversion installs)
  gv_python24:   No (disabled by default - for multiversion installs)
  gv_python25:   No (disabled by default - for multiversion installs)
  gv_python26:   No (disabled by default - for multiversion installs)
  gv_python27:   No (disabled by default - for multiversion installs)
  gv_python34:   No (disabled by default - for multiversion installs)
  gv_R:          No (R not available)
  gv_ruby:       Yes
  gv_tcl:        No (tcl not available)

  tcldot:        No (tcl not available)
  tclpathplan:   No (tcl not available)
  gdtclft:       No (tcl not available)

Testing utilities:
  criterion:     No (Criterion unit testing framework not installed)
==> ./configure --disable-debug --disable-dependency-tracking --prefix=/usr/local/Cellar/graphviz/2.40.1 --without-qt --with-quartz --disable-php --with-gts
----------------------------------------------------------------

graphviz-2.40.1 will be compiled with the following:

options:
  cgraph:        Yes (always enabled)
  digcola:       Yes
  expat:         Yes
  fontconfig:    Yes
  freetype:      Yes
  glut:          Yes
  ann:           No (ANN library not available)
  gts:           Yes
  ipsepcola:     No (disabled by default - C++ portability issues)
  ltdl:          Yes
  ortho:         Yes
  sfdp:          Yes
  shared:        Yes
  static:        No (disabled by default)
  qt:            No (disabled)
  x:             Yes

commands:
  dot:           Yes (always enabled)
  neato:         Yes (always enabled)
  fdp:           Yes (always enabled)
  circo:         Yes (always enabled)
  twopi:         Yes (always enabled)
  gvpr:          Yes (always enabled)
  gvmap:         Yes (always enabled)
  lefty:         Yes
  smyrna:        No (disabled by default - experimental)
  gvedit:        No (disabled)

plugin libraries:
  dot_layout:    Yes (always enabled)
  neato_layout:  Yes (always enabled)
  core:          Yes (always enabled)
  devil:         No (missing library)
  gd:            Yes
  gdiplus:       No (disabled by default - Windows only)
  gdk:           
  gdk_pixbuf:    Yes
  ghostscript:   Yes
  glitz:         No (disabled by default - incomplete)
  gtk:           No (gtk library not available)
  lasi:          No (lasi library not available)
  ming:          No (disabled by default - incomplete)
  pangocairo:    Yes
  poppler:       No (poppler library not available)
  quartz:        Yes
  rsvg:          Yes
  visio:         No (disabled by default - experimental)
  webp:          No (disabled by default - experimental)
  xlib:          Yes

language extensions:
  gv_sharp:      No (mcs not available)
  gv_go:         No (disabled by default - experimental)
  gv_guile:      No (guile not available)
  gv_io:         No (disabled by default - no swig support yet)
  gv_java:       Yes
  gv_lua:        No (lua not available)
  gv_ocaml:      No (ocaml not available)
  gv_perl:       Yes
  gv_php:        No (disabled)
  gv_python:     Yes
  gv_python23:   No (disabled by default - for multiversion installs)
  gv_python24:   No (disabled by default - for multiversion installs)
  gv_python25:   No (disabled by default - for multiversion installs)
  gv_python26:   No (disabled by default - for multiversion installs)
  gv_python27:   No (disabled by default - for multiversion installs)
  gv_python34:   No (disabled by default - for multiversion installs)
  gv_R:          No (R not available)
  gv_ruby:       Yes
  gv_tcl:        No (tcl not available)

  tcldot:        No (tcl not available)
  tclpathplan:   No (tcl not available)
  gdtclft:       No (tcl not available)

Testing utilities:
  criterion:     No (Criterion unit testing framework not installed)

instead of `--enable-php=no`.
@ilovezfs ilovezfs merged commit b7d1e92 into Homebrew:master Oct 23, 2017
@ilovezfs
Copy link
Contributor

Thanks @s172262!

@s172262 s172262 deleted the graphviz branch October 30, 2017 14:43
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants