Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpq@15: add libpq 15.8 #193209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

libpq@15: add libpq 15.8 #193209

wants to merge 2 commits into from

Conversation

mkobel
Copy link

@mkobel mkobel commented Oct 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 8, 2024
@github-actions github-actions bot added legacy Relates to a versioned @ formula and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 8, 2024
@mkobel mkobel marked this pull request as ready for review October 8, 2024 15:07
mkobel added 2 commits October 8, 2024 21:31
The formula is based on libpq formula with version 15.4
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Oct 29, 2024
@mkobel
Copy link
Author

mkobel commented Nov 1, 2024

@carlocab Is this PR acceptable as replacement of #193190 ?

@github-actions github-actions bot removed the stale No recent activity label Nov 1, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 23, 2024
@chenrui333 chenrui333 removed the stale No recent activity label Nov 26, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added stale No recent activity and removed stale No recent activity labels Dec 17, 2024
@carlocab carlocab requested a review from a team December 20, 2024 20:28
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one small fix needed.

Comment on lines +13 to +14
keg_only "conflicts with postgres formula"
keg_only :versioned_formula
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
keg_only "conflicts with postgres formula"
keg_only :versioned_formula
keg_only :versioned_formula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants