Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emqx: depend on erlang@26 #191439

Merged

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Sep 21, 2024

We're pining emqx to erlang@26 at this moment, since we're getting ready for erlang@27, not supported by the former.

Reasoning: it doesn't compile/work with OTP 27 yet.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title emqx: depend on erlang@26 emqx: depend on erlang@26 Sep 21, 2024
@paulo-ferraz-oliveira
Copy link
Contributor Author

There's #183297 but it handles a different issue, so a rebase (here, or there) might be in order depending on which PR gets merged first.

@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Sep 21, 2024
6 tasks
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the chore/emqx-erlang@26 branch 2 times, most recently from 9b841f0 to cf3e312 Compare September 21, 2024 11:03
@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review September 21, 2024 11:53
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into Homebrew:master with commit 84088e5 Sep 21, 2024
15 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the chore/emqx-erlang@26 branch September 21, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants