Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk@21: unbundle freetype on macOS #191408

Merged
merged 2 commits into from
Sep 21, 2024
Merged

openjdk@21: unbundle freetype on macOS #191408

merged 2 commits into from
Sep 21, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the legacy Relates to a versioned @ formula label Sep 20, 2024
@cho-m cho-m added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Sep 21, 2024
@calvinit
Copy link
Contributor

I noticed that you opened similar PRs for openjdk@11, openjdk@17, and openjdk@21. May I ask if openjdk@8 also needs similar handling?

@cho-m
Copy link
Member Author

cho-m commented Sep 21, 2024

May I ask if openjdk@8 also needs similar handling?

I don't think so as the freetype build logic has changed between OpenJDK 8 and 11. It may already be linked correctly as dependency is listed for all OS

depends_on "freetype"

Copy link
Contributor

@cho-m
Copy link
Member Author

cho-m commented Sep 21, 2024

Merging. embulk failure is unrelated and was fixed in #191470

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 21, 2024
Merged via the queue into master with commit f363fcd Sep 21, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the jdk21-freetype branch September 21, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. legacy Relates to a versioned @ formula
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants