Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvim mlx openjdk v8: add comment for xcode dependency #191393

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Keeping track of some xcode usage that is required as I am trying to remove unnecessary ones

@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 20, 2024
@github-actions github-actions bot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing labels Sep 20, 2024
@cho-m cho-m removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 20, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 3ca65aa Sep 20, 2024
19 checks passed
@chenrui333 chenrui333 deleted the xcode-reason branch September 20, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants