Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openvino 2024.4.0 #191090

Merged
merged 6 commits into from
Sep 23, 2024
Merged

openvino 2024.4.0 #191090

merged 6 commits into from
Sep 23, 2024

Conversation

artanokhov
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@artanokhov artanokhov marked this pull request as ready for review September 19, 2024 09:06
@artanokhov
Copy link
Contributor Author

Please add tags required for long-build, as we have in previous PR
#179077

@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Sep 19, 2024
chenrui333
chenrui333 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SMillerDev
Copy link
Member

This looks like a problem in @Homebrew/brew

  Error: An exception occurred within a child process:
    RuntimeError: `sig` not present for method `generic_std_cmake_args` on #<Formula opencv (stable) /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/o/opencv.rb> but you're trying to run it anyways. This should only be executed if you used `alias_method` to grab a handle to a method after `sig`ing it, but that clearly isn't what you are doing. Maybe look to see if an exception was thrown in your `sig` lambda or somehow else your `sig` wasn't actually applied to the method.

@carlocab
Copy link
Member

Think this is Homebrew/brew#18305. CC @dduugg

@carlocab carlocab mentioned this pull request Sep 20, 2024
Merged
7 tasks
MikeMcQuaid added a commit to Homebrew/brew that referenced this pull request Sep 20, 2024
@MikeMcQuaid
formula: fix alias/generic/prepend std_cmake_args issue.
7743c52 
Seen in:
Homebrew/homebrew-core#191090 (comment)

There's a missing signature issue here due to the `generic_*` aliasing
we're doing. With prepend, though: this is no longer needed and we can
use `super` instead which is more idiomatic and nicer overall.

This pattern should probably be applied in other places but: let's try
this targetting fix for here first.
@MikeMcQuaid MikeMcQuaid mentioned this pull request Sep 20, 2024
Merged
@MikeMcQuaid
Copy link
Member

Should be fixed by Homebrew/brew#18364

MikeMcQuaid added a commit to Homebrew/brew that referenced this pull request Sep 20, 2024
@MikeMcQuaid
formula: fix alias/generic/prepend std_cmake_args issue.
eab3229 
Seen in:
Homebrew/homebrew-core#191090 (comment)

There's a missing signature issue here due to the `generic_*` aliasing
we're doing. With prepend, though: this is no longer needed and we can
use `super` instead which is more idiomatic and nicer overall.

This pattern should probably be applied in other places but: let's try
this targetting fix for here first.
@artanokhov
Copy link
Contributor Author

Currently observing issue with downloading OpenCV manifest

==> Downloading https://ghcr.io/v2/homebrew/core/opencv/manifests/4.10.0_7
curl: (56) The requested URL returned error: 404

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 23, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 23, 2024
Merged via the queue into Homebrew:master with commit 91b5691 Sep 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions GitHub Actions github-actions approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@artanokhov @SMillerDev @carlocab @MikeMcQuaid @chenrui333 @BrewTestBot