-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove livecheck failures from autobump list #183126
base: master
Are you sure you want to change the base?
Conversation
d1426d5
to
a83e75c
Compare
if ! jq --exit-status '.state == "OPEN"' | ||
then | ||
gh pr create --fill | ||
fi < <(gh pr view --json=state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gh pr view
does not work well when there are multiple PRs with the same branch name. (Try to checkout a new branch named sponsors-maintainers-man-completions
in brew --repo
and see.) The sync-shared-config
workflow relies on the API for this reason.
The livecheck blocks for autobumped formulae can silently fail. Let's handle that by automatically removing them from the autobump list when that happens.
a83e75c
to
e78ea28
Compare
if: fromJSON(steps.commit.outputs.push) | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN }} | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: | | |
working-directory: ${{ steps.set-up-homebrew.outputs.repository-path }} | |
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far! Could this be part of the existing autobump workflow instead? Feels like having another workflow essentially doing autobump but not using the results is going to burn through our rate limits.
It could, but,
I don't think it will help with this, since it'll likely have to do |
I'm thinking that we could have something in e.g. Would also be nice to have more logic in Homebrew/brew and less in (more) workflows if possible. |
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
Yea, maybe. Here's a start: Homebrew/brew#18227 It then needs to handle removal from the autobump list when a step fails, but |
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
This will read from the tap's `.github/autobump.txt` when provided. See discussion at Homebrew/homebrew-core#183126.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The livecheck blocks for autobumped formulae can silently fail. Let's
handle that by automatically removing them from the autobump list when
that happens.