-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql-client: fix add authentication plugins in mysql-client@9.0 #181805
Conversation
297f0cb
to
ba8b9c8
Compare
This adds the `-DWITH_AUTHENTICATION_CLIENT_PLUGINS=yes` flag to add support for older MySQL authentication methods. This support was in the default build prior to MySQL 9.0, but were dropped with that release. Closes Homebrew#180498
ba8b9c8
to
0dc3ffd
Compare
Can you make an issue upstream requesting they enable this by default and add that as a comment? From the linked thread it seems like upstream thinks it's default already. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@SMillerDev I downloaded the MySQL Community Server 9.0.1 Innovation on macOS from https://dev.mysql.com/downloads/mysql/5.5.html?os=31&version=5.1, it gets
|
should reopen this merge request? |
If Oracle made it the default there is nothing for Homebrew to change. If they didn't, someone should make an issue about it on their side before we re-open anything. |
Filed bug upstream: https://bugs.mysql.com/bug.php?id=116616&thanks=4 To note, the quoted documentation in #180498 is from the MySQL 9.0 server release notes, which are likely not treated as "official" documentation by upstream. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This addresses #180498 .
The MySQL 9.0 client is not built with support for older authentication methods by default, which breaks the ability for the MySQL client, and packages that depend on it, to connect to servers still using authentication methods like
mysql_native_password
. This adjusts the build process to add those back in as plugins.