Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-server 4.91.1 #176894

Merged
merged 2 commits into from
Jul 20, 2024
Merged

code-server 4.91.1 #176894

merged 2 commits into from
Jul 20, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 10, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 13, 2024
@samford
Copy link
Member

samford commented Jul 13, 2024

ERROR: code-server currently requires node v20.

I updated this to depend on node@20 but there are still some other build failures:

npm error In file included from ../node_modules/node-addon-api/napi.h:2981:
npm error ../node_modules/node-addon-api/napi-inl.h:64:12: error: no matching function for call to 'napi_add_finalizer'
npm error   status = napi_add_finalizer(env, obj, data, finalizer, hint, nullptr);
npm error            ^~~~~~~~~~~~~~~~~~

@samford samford added build failure CI fails while building the software and removed stale No recent activity labels Jul 13, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 16, 2024
@branchvincent branchvincent force-pushed the bump-code-server-4.91.0 branch 2 times, most recently from 4228eaf to 8a14ed5 Compare July 20, 2024 04:45
Co-authored-by: Branch Vincent <branchevincent@gmail.com>
@branchvincent branchvincent changed the title code-server 4.91.0 code-server 4.91.1 Jul 20, 2024
@branchvincent branchvincent removed stale No recent activity build failure CI fails while building the software labels Jul 20, 2024
@branchvincent
Copy link
Member

Build failure is from nodejs/node#52229

@branchvincent branchvincent added the ready to merge PR can be merged once CI is green label Jul 20, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 20, 2024
Merged via the queue into master with commit af84f3e Jul 20, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the bump-code-server-4.91.0 branch July 20, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants