Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgcrypt 1.11.0, gnupg 2.5.1 #175100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

libgcrypt 1.11.0, gnupg 2.5.1 #175100

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` long dependent tests Set a long timeout for dependent testing labels Jun 19, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Jun 19, 2024
@chenrui333 chenrui333 added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jun 19, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 22, 2024
@chenrui333 chenrui333 added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner and removed stale No recent activity CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Jun 22, 2024
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Jun 22, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jun 22, 2024
@chenrui333 chenrui333 force-pushed the bump-libgcrypt-1.11.0 branch 2 times, most recently from 05ba368 to e981324 Compare June 23, 2024 16:59
@chenrui333 chenrui333 added the CI-requeued PR has been re-added to the queue label Jun 24, 2024
@bevanjkay bevanjkay mentioned this pull request Aug 5, 2024
@carlocab carlocab changed the title libgcrypt 1.11.0 libgcrypt 1.11.0, gnupg 2.5.0 Aug 5, 2024
@carlocab
Copy link
Member

carlocab commented Aug 5, 2024

We might need this patch (and maybe regenerate configure): https://dev.gnupg.org/rCbb0895bbb7c6d2b9502cbbf03da14d4ecf27a183

@bevanjkay bevanjkay force-pushed the bump-libgcrypt-1.11.0 branch 2 times, most recently from e93606e to 5ebe8db Compare August 5, 2024 13:48
@bevanjkay bevanjkay removed the CI-requeued PR has been re-added to the queue label Aug 5, 2024
@bevanjkay
Copy link
Member

 ../../scd/app.c:379:3: error: call to undeclared function 'write'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    write (card_list_lock.notify_pipe[1], "", 1);
    ^
  ../../scd/app.c:379:3: note: did you mean 'fwrite'?
  /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/stdio.h:157:9: note: 'fwrite' declared here
  size_t   fwrite(const void * __restrict __ptr, size_t __size, size_t __nitems, FILE * __restrict __stream) __DARWIN_ALIAS(fwrite);
           ^
  ../../scd/app.c:439:11: error: call to undeclared function 'read'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
            read (card_list_lock.notify_pipe[0], buf, sizeof buf);
            ^
  ../../scd/app.c:439:11: note: did you mean 'fread'?
  /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/stdio.h:150:9: note: 'fread' declared here
  size_t   fread(void * __restrict __ptr, size_t __size, size_t __nitems, FILE * __restrict __stream);
           ^
  2 errors generated.
  make[2]: *** [app.o] Error 1

@fxcoudert
Copy link
Member

  186 tests run, 183 succeeded, 3 failed, 0 failed expectedly, 0 succeeded unexpectedly, 0 skipped. 
  Failed tests: tests/openpgp/encrypt.scm tests/openpgp/compression.scm tests/openpgp/encrypt.scm 

All three terminate with:

  Checking encryption using a specific cipher algorithm 
      > IDEA ........ 3DES ........ CAST5 ........ BLOWFISH ........ AES ........ AES192 ....*** buffer overflow detected ***: terminated
  FAIL: <keyboxd>tests/openpgp/encrypt.scm 

@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 6, 2024
@carlocab
Copy link
Member

carlocab commented Sep 6, 2024

Seems to only be failing on Linux.

@carlocab carlocab changed the title libgcrypt 1.11.0, gnupg 2.5.0 libgcrypt 1.11.0, gnupg 2.5.1 Sep 15, 2024
@fxcoudert
Copy link
Member

Still the same Linux-only failure:

  PASS: <keyring>tests/openpgp/key-selection.scm 
  *** buffer overflow detected ***: terminated
  FAIL: <keyring>tests/openpgp/delete-keys.scm 
  Checking reading and writing configuration via gpgconf...  
      > compliance ............. verbose ............. quiet ............. <  
  PASS: <keyring>tests/openpgp/gpgconf.scm 
  Checking passphrase cache (issue2015)... 
  PASS: <keyring>tests/openpgp/issue2015.scm 
  Checking import statistics (issue2346)... 
  PASS: <keyring>tests/openpgp/issue2346.scm 
  Checking robustness wrt empty databases in gnupghome (issue2417)... 
  PASS: <keyring>tests/openpgp/issue2417.scm 
  Checking iobuf_peek corner case (issue2419)... 
  PASS: <keyring>tests/openpgp/issue2419.scm 
  Checking TOFU trust model with ultimately trusted keys (issue2929). 
  PASS: <keyring>tests/openpgp/issue2929.scm 
  Checking invocation with invalid file descriptors (issue2941). 
      > status-fd attribute-fd logger-fd override-session-key-fd passphrase-fd command-fd <  
  PASS: <keyring>tests/openpgp/issue2941.scm 
  =================== 
  186 tests run, 179 succeeded, 7 failed, 0 failed expectedly, 0 succeeded unexpectedly, 0 skipped. 
  Failed tests: tests/openpgp/delete-keys.scm tests/openpgp/clearsig.scm tests/openpgp/encrypt-dsa.scm tests/openpgp/gpgconf.scm tests/openpgp/gpgconf.scm tests/openpgp/trust-pgp-1.scm tests/openpgp/compression.scm 
  =================== 

@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 15, 2024
@carlocab
Copy link
Member

Still failed, but it did seem to make some of the failures go away:

  =================== 
  186 tests run, 182 succeeded, 4 failed, 0 failed expectedly, 0 succeeded unexpectedly, 0 skipped. 
  Failed tests: tests/openpgp/conventional-mdc.scm tests/openpgp/encrypt-dsa.scm tests/openpgp/trust-pgp-2.scm tests/openpgp/clearsig.scm 
  =================== 

@stefanb stefanb mentioned this pull request Sep 16, 2024
@cho-m cho-m removed the in progress Stale bot should stay away label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Nov 7, 2024
@github-actions github-actions bot closed this Nov 9, 2024
@github-actions github-actions bot deleted the bump-libgcrypt-1.11.0 branch November 9, 2024 00:12
@daeho-ro daeho-ro restored the bump-libgcrypt-1.11.0 branch November 9, 2024 02:27
@daeho-ro daeho-ro reopened this Nov 9, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 9, 2024
autobump: add libgcrypt

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot removed the stale No recent activity label Nov 9, 2024
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@SMillerDev
Copy link
Member

On Linux:

Failed tests: tests/openpgp/trust-pgp-3.scm tests/openpgp/encrypt-dsa.scm tests/openpgp/issue2929.scm tests/openpgp/gpgconf.scm tests/openpgp/conventional.scm tests/openpgp/armencrypt.scm tests/openpgp/encrypt.scm tests/openpgp/sigs.scm tests/openpgp/tofu.scm tests/openpgp/conventional.scm tests/openpgp/encrypt.scm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants