Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-builder 46.2 (new formula) #174023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valentinegb
Copy link
Contributor

@valentinegb valentinegb commented Jun 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adds formula for GNOME Builder v46.2.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 8, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jun 8, 2024
@chenrui333
Copy link
Member

FAILED: src/libdex-1.a.p/dex-main-scheduler.c.o 
clang -Isrc/libdex-1.a.p -Isrc -I../src -I/usr/local/Cellar/pcre2/10.43/include -I/usr/local/Cellar/glib/2.80.2/include -I/usr/local/Cellar/glib/2.80.2/include/glib-2.0 -I/usr/local/Cellar/glib/2.80.2/lib/glib-2.0/include -I/usr/local/opt/gettext/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -I/private/tmp/gnome-builder--libdex-20240608-20972-dl9yng/libdex-0.6.1/build -fvisibility=hidden -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=gnu11 -O3 -Watomic-alignment -Wcast-align -Wdeclaration-after-statement -Werror=address -Werror=array-bounds -Werror=empty-body -Werror=implicit -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=init-self -Werror=int-conversion -Werror=int-to-pointer-cast -Werror=main -Werror=misleading-indentation -Werror=missing-braces -Werror=missing-include-dirs -Werror=nonnull -Werror=overflow -Werror=pointer-arith -Werror=pointer-to-int-cast -Werror=redundant-decls -Werror=return-type -Werror=sequence-point -Werror=shadow -Werror=strict-prototypes -Werror=trigraphs -Werror=undef -Werror=write-strings -Wformat-nonliteral -Wignored-qualifiers -Wimplicit-function-declaration -Wmissing-declarations -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wno-cast-function-type -Wno-missing-field-initializers -Wno-sign-compare -Wno-unused-parameter -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wswitch-default -Wswitch-enum -Wundef -Wuninitialized -Wunused -fno-strict-aliasing -Werror=format-security -Werror=format=2 -FImsvc_recommended_pragmas.h -fstack-protector-strong -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_68 -DG_DISABLE_ASSERT '-DG_LOG_DOMAIN="Dex"' -DDEX_COMPILATION -D_XOPEN_SOURCE -MD -MQ src/libdex-1.a.p/dex-main-scheduler.c.o -MF src/libdex-1.a.p/dex-main-scheduler.c.o.d -o src/libdex-1.a.p/dex-main-scheduler.c.o -c ../src/dex-main-scheduler.c
In file included from ../src/dex-main-scheduler.c:25:

In file included from ../src/dex-fiber-private.h:30:
In file included from ../src/dex-ucontext-private.h:88:
../src/amd64-ucontext.h:6:15: error: conflicting types for 'swapcontext'
extern  int   swapcontext(ucontext_t*, const ucontext_t*);
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ucontext.h:47:6: note: previous declaration is here
int  swapcontext(ucontext_t * __restrict, const ucontext_t * __restrict);
     ^
In file included from ../src/dex-main-scheduler.c:25:
In file included from ../src/dex-fiber-private.h:30:
In file included from ../src/dex-ucontext-private.h:88:
../src/amd64-ucontext.h:7:15: error: conflicting types for 'makecontext'
extern  void  makecontext(ucontext_t*, void(*)(void), int, ...);
              ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ucontext.h:41:6: note: previous declaration is here
void makecontext(ucontext_t *, void (*)(), int, ...);
     ^
2 errors generated.

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jun 8, 2024
@valentinegb
Copy link
Contributor Author

Upstream issue for build failure: https://gitlab.gnome.org/GNOME/libdex/-/issues/19

@valentinegb valentinegb force-pushed the gnome-builder branch 7 times, most recently from a983e62 to 60726c4 Compare June 12, 2024 19:32
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jun 20, 2024
@valentinegb valentinegb force-pushed the gnome-builder branch 5 times, most recently from e70e04d to edb2ca0 Compare July 9, 2024 02:11
@valentinegb
Copy link
Contributor Author

Upstream issue for build failure: https://gitlab.gnome.org/GNOME/libdex/-/issues/19

This build failure has been resolved in the next version of libdex and the fix has been patched into the version used in this formula. The checks now only fail because of the use of patches.

Formula/g/gnome-builder.rb Outdated Show resolved Hide resolved
Formula/g/gnome-builder.rb Outdated Show resolved Hide resolved
Formula/g/gnome-builder.rb Show resolved Hide resolved
@valentinegb valentinegb force-pushed the gnome-builder branch 3 times, most recently from 8488d1f to c068641 Compare July 10, 2024 20:36
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 17, 2024
@valentinegb
Copy link
Contributor Author

As far as I'm aware, no action needs to be taken on my end, I'm just waiting for this to get merged.

@github-actions github-actions bot removed the stale No recent activity label Aug 17, 2024
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Aug 17, 2024
@chenrui333
Copy link
Member

chenrui333 commented Aug 17, 2024

what is the status with the patch in this PR?


I am seeing this has been closed, https://gitlab.gnome.org/GNOME/libdex/-/issues/19

@valentinegb
Copy link
Contributor Author

valentinegb commented Aug 17, 2024

The problem that the patch addresses is fixed in the next version of libdex. I just checked and it looks like the next version has been released now, so we could probably use that version and remove the patch now. (Edit: I've gone ahead and done that ^^)

@valentinegb
Copy link
Contributor Author

Is the "in progress" tag really appropriate? Since I'm, again, not actively working on this! I'm just waiting to be told what's to happen next.

@SMillerDev SMillerDev removed their request for review September 11, 2024 09:18
@fxcoudert
Copy link
Member

  Indirect dependencies with linkage:
    cairo
    icu4c
    libxml2
    pango

Please check whether this linkage is expected, and if so, add them as direct dependencies.

@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Sep 11, 2024
@valentinegb
Copy link
Contributor Author

libxml2 does not appear to be needed on my Apple Silicon Mac running macOS 15, but I'm not sure about other architectures, versions, or on Linux. Also, gettext is needed too on my Mac, but again I'm not sure about in other cases.

@github-actions github-actions bot removed the icu4c ICU use is a significant feature of the PR or issue label Sep 11, 2024
@valentinegb
Copy link
Contributor Author

Hopefully the changes I just made are sufficient, let me know if they aren't ^^'

@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Sep 11, 2024
depends_on "gobject-introspection"
depends_on "gtk4"
depends_on "gtksourceview5"
depends_on "icu4c" # GNOME Builder uses dylibs from icu4c not included in macOS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew audit --new gnome-builder returns "Dependency 'icu4c' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.", but, see this comment.

@valentinegb
Copy link
Contributor Author

The "build failure" label should probably be removed, since there isn't any build failure to worry about now

@SMillerDev SMillerDev removed the build failure CI fails while building the software label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. icu4c ICU use is a significant feature of the PR or issue in progress Stale bot should stay away new formula PR adds a new formula to Homebrew/homebrew-core upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants