-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnome-builder 46.2 (new formula) #174023
base: master
Are you sure you want to change the base?
gnome-builder 46.2 (new formula) #174023
Conversation
|
72147d8
to
5594aab
Compare
Upstream issue for build failure: https://gitlab.gnome.org/GNOME/libdex/-/issues/19 |
a983e62
to
60726c4
Compare
e70e04d
to
edb2ca0
Compare
This build failure has been resolved in the next version of libdex and the fix has been patched into the version used in this formula. The checks now only fail because of the use of patches. |
8488d1f
to
c068641
Compare
c068641
to
4e3d05e
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
As far as I'm aware, no action needs to be taken on my end, I'm just waiting for this to get merged. |
what is the status with the patch in this PR? I am seeing this has been closed, https://gitlab.gnome.org/GNOME/libdex/-/issues/19 |
The problem that the patch addresses is fixed in the next version of |
4e3d05e
to
d2e175c
Compare
Is the "in progress" tag really appropriate? Since I'm, again, not actively working on this! I'm just waiting to be told what's to happen next. |
Please check whether this linkage is expected, and if so, add them as direct dependencies. |
d2e175c
to
a516162
Compare
|
a516162
to
ef70ae4
Compare
Hopefully the changes I just made are sufficient, let me know if they aren't ^^' |
ef70ae4
to
31ef45c
Compare
depends_on "gobject-introspection" | ||
depends_on "gtk4" | ||
depends_on "gtksourceview5" | ||
depends_on "icu4c" # GNOME Builder uses dylibs from icu4c not included in macOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brew audit --new gnome-builder
returns "Dependency 'icu4c' is provided by macOS; please replace 'depends_on' with 'uses_from_macos'.", but, see this comment.
The "build failure" label should probably be removed, since there isn't any build failure to worry about now |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Adds formula for GNOME Builder v46.2.