Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Mar 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Allows us to introduce .crate handling to brew without breaking existing formulae usage.

cho-m added 5 commits March 26, 2024 09:38
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Mar 26, 2024
@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue long build Set a long timeout for formula testing labels Mar 26, 2024
@cho-m cho-m added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Mar 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit 5aef674 Mar 27, 2024
@BrewTestBot BrewTestBot deleted the crate-nounzip branch March 27, 2024 17:23
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI-no-bottles Merge without publishing bottles CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. long build Set a long timeout for formula testing outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants