Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bumpCreated with
brew bump-formula-pr.release notes
rebase_orderas the primary key for thedolt_rebasesystem tableCurrently every push results in the message "[new branch] ..." which is misleading. Unfortunately fixing this for all updates is way harder than I want to dig into at the moment, so I'm going to make the only case we can detect easily (delete) print a better message.
Adds support for an interactive rebase workflow with Dolt. This allows users to edit their commit history, including rewording commit messages, reordering commits, dropping commits, and squashing multiple commits together. At the end of an interactive rebase, the current branch points to a new commit history created by executing the rebase plan the user specified.
dolt rebasedolthub/dolt#3467go-mysql-server
utc_timestampThe
UTC_TIMESTAMP()function should take in an argument and round the milliseconds. For now, we stick to always returning the full precision (6 places)fixes Panic when Using
INNER JOINdolthub/dolt#7235Replace the logic in
Between.Eval()with a logically equivalentANDstatement to reuse the type conversion logic incomparison.gofixes Unexpected Results when Using BETWEEN and LEFT JOIN dolthub/dolt#7229
JsonIterclass for iterating over the key-value pairs of a JSON object.This is the GMS side of automating JSON merging in Dolt: just some type aliases and a simple iterator for getting the keys in a JSON object in a deterministic order.
It's worth pointing out that currently Dolt stores JSON in a normalized form by sorting keys by length, but the iterator here uses a simple lexicographic order instead. This difference doesn't really matter at the moment because we unmarshall the entire object into a go map no matter what. But Dolt needs to be aware of the ordering used in order to correctly compute three-way diffs.
NOW()siblingsThis PR has our behavior surrounding
NOW()functions more closely match MySQL.Changes:
NOW()synonyms to registryCURRENT_TIMESTAMP(),LOCALTIME(),LOCALTIMESTAMP()all just callNOW()DEFAULTandON UPDATEexpressionsSHOW CREATE TABLEto printCURRENT_TIMESTAMPforNOW()and synonymsCompanion PR: refactoring
defaultandon updateexpressions dolthub/vitess#296Fixes:
current_timestampsynonyms dolthub/dolt#7129current_timestamp()andnow()do not return the same values dolthub/dolt#6058Fix wrongly written word 'aribtrary' -> 'arbitrary'
vitess
versionkeyword to not require identifier quotesThe
versionkeyword still required identifier quoting in some usages, such asSELECT * FROM base.version;. See Unable to query tables namedversionin another database without escaping dolthub/dolt#7237 for more details.This change moves the
versionkeyword into the main list of non-reserved keywords. There was one conflict from use of theversionkeyword in thefunction_call_keywordrule, but it turns out that use ofversionthere is not required. We have an existing test for using theversion()function, so I didn't add a new one.defaultandon updateexpressionsThis PR changes the grammar to more closely match MySQL's behavior, specifically around the
NOW()function and its synonyms.Changes:
ON UPDATEexpressions against functinos that aren'tNOW()or a synonym.NOW()and synonyms; syntax error for anything elseCurTimeFuncExprfrom AST in favor of plainFuncExprCompanion PR: implement
NOW()siblings dolthub/go-mysql-server#2218Previously, an inline column check constraint could only appear as the very last option for a column definition. This change allows it to appear in other positions in the column definition. For example, this query now works:
CREATE TABLEwith bothCHECKandNOT NULLdolthub/dolt#7195Closed Issues
current_timestamp()andnow()do not return the same valuescurrent_timestampsynonymsINNER JOINdolt rebase