Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust 2.69.3 #154376

Merged
merged 4 commits into from
Nov 20, 2023
Merged

faust 2.69.3 #154376

merged 4 commits into from
Nov 20, 2023

Conversation

Porkepix
Copy link
Contributor

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Nov 15, 2023
@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Nov 15, 2023
@chenrui333
Copy link
Member

need a long build for another run

@chenrui333 chenrui333 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 16, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 16, 2023
@Porkepix
Copy link
Contributor Author

Looks like it didn't need a long build?

@chenrui333
Copy link
Member

Looks like it didn't need a long build?

https://github.com/Homebrew/homebrew-core/actions/runs/6877700742/attempts/1
image

this did timeout in the first attempt

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 16, 2023
@Porkepix
Copy link
Contributor Author

Yep, but cancels can happens for other reasons, right? Here it just said "Error: The operation was canceled." after 45 minutes and nothing more.

Because the run that passed here had the longest job taking 42 minutes. (Though, I've already seen huge duration differences from one run to another).

@p-linnane
Copy link
Member

arm64 runners have a 45 minute timeout, while x86_64 has 90 minutes.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 16, 2023
@Porkepix
Copy link
Contributor Author

arm64 runners have a 45 minute timeout, while x86_64 has 90 minutes.

Eh didn't knew about that, thought it was 90 everywhere. Doesn't explain though why it took so much time while next run took much much less.

@p-linnane
Copy link
Member

Yeah if a job on arm64 needs more than 45 minutes the odds are very good it will need more than 90 on x86_64. For this, faust was probably pulled from the bottle cache on the last run, and this latest run only had to build csound.

@chenrui333 chenrui333 removed ready to merge PR can be merged once CI is green CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. labels Nov 16, 2023
@chenrui333
Copy link
Member

needs a rebase and re-bottle due to the merge conflict with csound py3.12 update, #154412

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Nov 19, 2023
@github-actions github-actions bot closed this Nov 20, 2023
auto-merge was automatically disabled November 20, 2023 03:46

Pull request was closed

@ZhongRuoyu ZhongRuoyu reopened this Nov 20, 2023
Porkepix and others added 2 commits November 20, 2023 17:59
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 20, 2023
@ZhongRuoyu ZhongRuoyu added CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. and removed stale No recent activity autosquash Automatically squash pull request commits according to Homebrew style. labels Nov 20, 2023
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Nov 20, 2023
Merged via the queue into Homebrew:master with commit 4f552c2 Nov 20, 2023
17 of 18 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Nov 20, 2023
@ZhongRuoyu
Copy link
Member

csound rebuilt and published at #154880.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants