cmu-pocketsphinx 5.0.0 #123396
Closed
cmu-pocketsphinx 5.0.0 #123396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Feb 16, 2023
I think it's an upstream bug. I'll push a fix to check. |
Tested the patch locally and it appears to do the trick (I'm seeing |
samford
force-pushed
the
cmu-pocketsphinx-5.0.0
branch
2 times, most recently
from
56f9415
to
7764a32
Compare
|
Can you send the patch upstream? You can point them at the docs for why the need the trailing slash. |
Upstream PR for the patch can now be found at cmusphinx/pocketsphinx#332. Edit: Merged. I've updated this to use the upstream commit patch instead of the previous inline patch. |
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Co-authored-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
samford
force-pushed
the
cmu-pocketsphinx-5.0.0
branch
from
7764a32
to
0a106be
Compare
22 tasks
carlocab
approved these changes
Feb 17, 2023
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?There's a new PocketSphinx release for the first time in years, so this PR updates the formula to 5.0.0 (released 2022-10-05). With this update, SphinxBase is no longer required and we should be able to deprecate the
cmu-sphinxbaseformula afterward.Some things to note:
cmakeinstructions from theREADMEbut let me know if we prefer something different.include/includeinstead ofinclude(e.g.,include/include/pocketsphinxandinclude/include/pocketsphinx.h). I've labeled this "do not merge" until we can resolve this issue. I tinkered with theCMakeLists.txtfile and looked around at other formulae but wasn't able to find a good solution. It's probably something obvious that I'm overlooking, so I'm open to suggestions.