Skip to content

Conversation

@CarterLi
Copy link
Contributor

Two build dependencies were added for image logo support

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@SMillerDev SMillerDev changed the title Fastfetch: update to 1.8.0 fastfetch 1.8.0 Dec 29, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is never used at runtime? That's very unusual.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All runtime dependencies in fastfetch are dynamically loaded with dlopen. I didn't make it a hard dependency because they are rarely used. People can install the dependencies if they need them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's a runtime dependency then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a dependency cannot be found at runtime, the feature that uses the dependency is disabled, which doesn't make the whole program unusable.

@CarterLi
Copy link
Contributor Author

CarterLi commented Dec 29, 2022

That's weird. glibc is a hard dependency of chafa but it can't be found when building

Two build dependencies were added for image logo support
@CarterLi CarterLi requested a review from SMillerDev December 29, 2022 17:04
@CarterLi
Copy link
Contributor Author

I decided to fix the build issue upstream.

@CarterLi CarterLi closed this Dec 29, 2022
@chenrui333
Copy link
Member

I decided to fix the build issue upstream.

that is what we would do :)

CarterLi added a commit to fastfetch-cli/fastfetch that referenced this pull request Dec 29, 2022
@chenrui333
Copy link
Member

#119443

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

superseded PR was replaced by another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants