-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
fastfetch 1.8.0 #119329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastfetch 1.8.0 #119329
Conversation
Formula/fastfetch.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is never used at runtime? That's very unusual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All runtime dependencies in fastfetch are dynamically loaded with dlopen. I didn't make it a hard dependency because they are rarely used. People can install the dependencies if they need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's a runtime dependency then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a dependency cannot be found at runtime, the feature that uses the dependency is disabled, which doesn't make the whole program unusable.
|
That's weird. |
Two build dependencies were added for image logo support
|
I decided to fix the build issue upstream. |
that is what we would do :) |
Makes homebrew happy Homebrew/homebrew-core#119329
Two build dependencies were added for image logo support
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?