Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devd: backport go modules to drop dep dependency #110550

Closed
wants to merge 1 commit into from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 13, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Potential way to re-deprecate dep -- #106902

Alternative (or in addition), we could deprecate devd.

@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Sep 13, 2022
@cho-m cho-m marked this pull request as ready for review September 15, 2022 02:20
@cho-m cho-m added the maintainer feedback Additional maintainers' opinions may be needed label Sep 15, 2022
@danielnachun danielnachun requested a review from a team September 20, 2022 03:46
@SMillerDev
Copy link
Member

Could we ask for a release upstream?

@cho-m
Copy link
Member Author

cho-m commented Sep 20, 2022

We requested one ~1.5 years ago (cortesi/devd#115) and upstream hasn't responded. Last commit was from 2020.

So, if we need a new release, then rather than us continuing to stall on upstream response, we may as well deprecate now.

@carlocab
Copy link
Member

Let's merge this and deprecate.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 to merge and deprecate.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@cho-m cho-m deleted the devd-drop-dep branch September 20, 2022 17:33
@cho-m cho-m mentioned this pull request Sep 21, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants