-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdcm, itk, vtk@8.2: drops, migrations, and re-deprecation #107657
Conversation
-DITK_USE_SYSTEM_DOUBLECONVERSION=ON | ||
-DITK_USE_SYSTEM_LIBRARIES=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled general ITK_USE_SYSTEM_LIBRARIES
. Also added ITK_USE_SYSTEM_DOUBLECONVERSION
, which isn't enabled by general option and needs to be manually set.
Note that there is a bundled copy of openjpeg
that cannot be dropped due to InsightSoftwareConsortium/ITK#1807
-DBUILD_TESTING=OFF | ||
-DCMAKE_INSTALL_RPATH:STRING=#{lib} | ||
-DCMAKE_INSTALL_NAME_DIR:STRING=#{lib} | ||
-DITK_USE_64BITS_IDS=ON | ||
-DITK_USE_STRICT_CONCEPT_CHECKING=ON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped BUILD_TESTING
as it is part of std_cmake_args
.
Dropped ITK_USE_STRICT_CONCEPT_CHECKING
as no longer used https://github.com/InsightSoftwareConsortium/ITK/blob/v5.2.1/CMakeLists.txt#L485-L487
if(ITK_USE_STRICT_CONCEPT_CHECKING)
message(WARNING "Compilers requiring ITK_USE_STRICT_CONCEPT_CHECKING are no longer suppported. This variable is no longer used.")
endif()
Other changes are mainly re-ordering.
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?jpeg-turbo
,python@3.10
, andffmpeg
#107250