Skip to content

Conversation

@carlocab
Copy link
Member

@carlocab carlocab commented Jul 3, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We often struggle with merging boost and icu4c updates due to merge
conflicts. The same occasionally happens with ffmpeg updates.

Let's make it easier to identify PRs that could potentially cause merge
conflicts with appropriate labels.

We often struggle with merging boost and icu4c updates due to merge
conflicts. The same occasionally happens with ffmpeg updates.

Let's make it easier to identify PRs that could potentially cause merge
conflicts with appropriate labels.
@carlocab carlocab requested a review from a team July 3, 2022 13:25
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 3, 2022
@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Jul 3, 2022
@SMillerDev
Copy link
Member

Would it be possible to make these work as "do not merge" if any of those dependents are in an approved review?

@carlocab
Copy link
Member Author

carlocab commented Jul 3, 2022

Would it be possible to make these work as "do not merge" if any of those dependents are in an approved review?

All the time? Or only when a relevant PR is open? Why wait until an approved review?

@carlocab carlocab merged commit 93f2216 into Homebrew:master Jul 3, 2022
@carlocab carlocab deleted the extra-dep-labels branch July 3, 2022 14:35
@SMillerDev
Copy link
Member

Only if there is for example: an icu4c PR that has been approved.

@carlocab
Copy link
Member Author

carlocab commented Jul 3, 2022

I don't see why it's not possible, but implementing it might take a bit of work. Here's an easy way to add the labels from the command-line, though:

gh pr list --label 'icu4c' | cut -f1 | xargs -L1 gh pr edit --add-label 'do not merge'

@github-actions github-actions bot added the outdated PR was locked due to age label Aug 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants