Skip to content

Conversation

@nektro
Copy link
Contributor

@nektro nektro commented Jun 26, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

follow up to #97618

zig 0.9.1 and master both still use llvm13. once 0.10.0 is released it can be updated again to be llvm@14

@SMillerDev
Copy link
Member

Does it fail with 14?

@carlocab carlocab changed the title zig uses llvm@13 zig: use llvm@13 Jun 27, 2022
@nektro
Copy link
Contributor Author

nektro commented Jun 27, 2022

yes

@cho-m
Copy link
Member

cho-m commented Jun 29, 2022

Since this modifies dependency, it should have a revision bump to distribute change to users. This can be done by adding revision 1 on line after the license

@matthewsanetra
Copy link

@nektro Apologies, just a polite reminder about this PR!

@cho-m cho-m mentioned this pull request Jul 6, 2022
6 tasks
@chenrui333
Copy link
Member

upstream is trying to upgrade to support llvm@14, ziglang/zig#12001

sha256 "38cf4e84481f5facc766ba72783e7462e08d6d29a5d47e3b75c8ee3142485210"
license "MIT"
revision 1
head "https://github.com/ziglang/zig.git"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be actually great to specify the default branch, but I think we can followup in the next run.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@nektro nektro deleted the patch-1 branch July 6, 2022 23:07
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants