Update perforce from 19.1-1845410 to 19.1-1865205 #70981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
added a commit
to dscho/git
that referenced
this pull request
Oct 17, 2019
It still fails! *Still!* Even after upgrading the cask's definition in the PR Homebrew/homebrew-cask#70981 does it fail. The explanation is, as Gábor Szeder dug out from the commit history: the local definitions might get stale and need to be updated. So let's just update them in case `brew cask install perforce` fails, and just try again! This will still fail, of course, when `homebrew-cask` falls behind Perforce's release schedule. But once it is updated, we can now simply re-run the failed jobs and they will pick up that update. As to updating `homebrew-cask`: I started automating this, via https://dev.azure.com/gitgitgadget/git/_build?definitionId=11&_a=summary (I plan on finishing it once the next Perforce upgrade comes around.) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/git
that referenced
this pull request
Oct 17, 2019
It still fails! *Still!* Even after upgrading the cask's definition in the PR Homebrew/homebrew-cask#70981 does it fail. The explanation is, as Gábor Szeder dug out from the commit history: the local definitions might get stale and need to be updated. So let's just update them in case `brew cask install perforce` fails, and just try again! This will still fail, of course, when `homebrew-cask` falls behind Perforce's release schedule. But once it is updated, we can now simply re-run the failed jobs and they will pick up that update. As to updating `homebrew-cask`: I started automating this, via https://dev.azure.com/gitgitgadget/git/_build?definitionId=11&_a=summary (I plan on finishing it once the next Perforce upgrade comes around.) Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making all changes to the cask:
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}reports no offenses.I don't have a macOS machine available to test all these. The problem was detected during a PR build: https://dev.azure.com/gitgitgadget/git/_build/results?buildId=18491&view=logs. I updated the values following https://github.com/Homebrew/homebrew-cask/pull/68754/files as an example, using the SHA-256 value from the failed build and the version number from https://www.perforce.com/downloads/helix-core-p4d.