Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more Homebrew-duplicated code. #23359

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Remove more Homebrew-duplicated code. #23359

merged 1 commit into from
Aug 2, 2016

Conversation

MikeMcQuaid
Copy link
Member

This may well cause some test failures but I'll debug them if it does and it behaves well enough with a quick brew cask fetch virtualbox local smoke test .

CC @AnastasiaSulyagina

@MikeMcQuaid
Copy link
Member Author

Hooray, this is finally green. The main thing that warrants mention is that tests are now run with brew cask-tests. This is because Homebrew's tests also rely on brew tests being run and Homebrew's Bash layer now sets a bunch of environment variables that are later needed by global.rb and it doesn't make sense to duplicate them here.

@jawshooah jawshooah merged commit 9cb7617 into Homebrew:master Aug 2, 2016
@jawshooah
Copy link
Contributor

Awesome, thanks @MikeMcQuaid!

@MikeMcQuaid MikeMcQuaid deleted the remove-more-homebrew-duplication branch August 3, 2016 17:02
@adidalal adidalal mentioned this pull request Aug 4, 2016
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @jawshooah